[Scummvm-git-logs] scummvm master -> 28285eac0b9ac732e3db1f0ccf40f844d04e216a

bluegr noreply at scummvm.org
Sun Oct 12 11:04:06 UTC 2025


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
28285eac0b COMMON: Don't use atomic writes in DefaultSaveFileManager


Commit: 28285eac0b9ac732e3db1f0ccf40f844d04e216a
    https://github.com/scummvm/scummvm/commit/28285eac0b9ac732e3db1f0ccf40f844d04e216a
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2025-10-12T14:04:01+03:00

Commit Message:
COMMON: Don't use atomic writes in DefaultSaveFileManager

Fixes save I/O failures on all platforms with atomic writes enabled.
Fixes save I/O failures specific to (at least) Windows.

Fixes Phantasmagoria regressions, bugs #15700 and #16269

Changed paths:
    backends/saves/default/default-saves.cpp


diff --git a/backends/saves/default/default-saves.cpp b/backends/saves/default/default-saves.cpp
index 0acc05bfcbe..95874945d57 100644
--- a/backends/saves/default/default-saves.cpp
+++ b/backends/saves/default/default-saves.cpp
@@ -164,7 +164,7 @@ Common::OutSaveFile *DefaultSaveFileManager::openForSaving(const Common::String
 	}
 
 	// Open the file for saving.
-	Common::SeekableWriteStream *const sf = fileNode.createWriteStream();
+	Common::SeekableWriteStream *const sf = fileNode.createWriteStream(false);
 	if (!sf)
 		return nullptr;
 	Common::OutSaveFile *const result = new Common::OutSaveFile(compress ? Common::wrapCompressedWriteStream(sf) : sf);




More information about the Scummvm-git-logs mailing list