[Scummvm-git-logs] scummvm master -> 12f5a3292748870b73988bf5c57069f4f9d5b1d0

[sev-]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
12f5a32927 DIRECTOR: LINGO: Implement mock-up for 'drawRect of window'


Commit: 12f5a3292748870b73988bf5c57069f4f9d5b1d0
    https://github.com/scummvm/scummvm/commit/12f5a3292748870b73988bf5c57069f4f9d5b1d0
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2025-09-02T00:46:13+02:00

Commit Message:
DIRECTOR: LINGO: Implement mock-up for 'drawRect of window'

The original does make distinction between Rect, FileRect and drawRect.

The latter "can be useful for scaling or panning movies."

We still do not implement the stretching.

So, issue a warning and use 'rect of window' for the time being.

Changed paths:
    engines/director/lingo/lingo-object.cpp


diff --git a/engines/director/lingo/lingo-object.cpp b/engines/director/lingo/lingo-object.cpp
index 6bcd48387ba..a6f3cf5debf 100644
--- a/engines/director/lingo/lingo-object.cpp
+++ b/engines/director/lingo/lingo-object.cpp
@@ -794,6 +794,11 @@ Datum Window::getField(int field) {
 	case kTheFileName:
 		return getFileName();
 	case kTheDrawRect:
+		warning("Window::getField: poorly handled getting field 'drawRect'");
+		ensureMovieIsLoaded();
+
+		// TODO: This should allow stretching or panning
+		return getStageRect();
 	case kTheSourceRect:
 	// case kTheImage:
 	// case kThePicture::
@@ -819,6 +824,9 @@ bool Window::setField(int field, const Datum &value) {
 	case kTheWindowType:
 		setWindowType(value.asInt());
 		return true;
+	case kTheDrawRect:
+		warning("Window::setField: poorly handled setting field 'drawRect'");
+		// fallthrough
 	case kTheRect:
 		return setStageRect(value);
 	case kTheModal: