[Scummvm-git-logs] scummvm master -> 3f075386a89ce3bac0f99e8f67d1fbdfd96a3795

sev- noreply at scummvm.org
Wed Sep 3 19:16:20 UTC 2025


This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
5579f8c744 DIRECTOR: DT: Fix channel bbox drawing on selecting the channel
3f075386a8 DIRECTOR: Redraw frame on 'draw' debug command


Commit: 5579f8c744e9e7587f0d083fc4593a22636b918c
    https://github.com/scummvm/scummvm/commit/5579f8c744e9e7587f0d083fc4593a22636b918c
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2025-09-03T21:16:09+02:00

Commit Message:
DIRECTOR: DT: Fix channel bbox drawing on selecting the channel

Also, implemented the same functionality in the Score window

Changed paths:
    engines/director/debugger/dt-score.cpp


diff --git a/engines/director/debugger/dt-score.cpp b/engines/director/debugger/dt-score.cpp
index 1a3b9a0883c..e5eb435f908 100644
--- a/engines/director/debugger/dt-score.cpp
+++ b/engines/director/debugger/dt-score.cpp
@@ -188,6 +188,15 @@ static void displayScoreChannel(int ch, int mode, int modeSel) {
 		if (ImGui::IsItemClicked(0)) {
 			_state->_selectedScoreCast.frame = f + _state->_scoreFrameOffset - 1;
 			_state->_selectedScoreCast.channel = ch;
+
+			if (f + _state->_scoreFrameOffset == (int)currentFrameNum) {
+				if (_state->_selectedChannel == ch)
+					_state->_selectedChannel = -1;
+				else
+					_state->_selectedChannel = ch;
+
+				g_director->getCurrentWindow()->render(true);
+			}
 		}
 	}
 
@@ -620,10 +629,11 @@ void showChannels() {
 				if (ImGui::Selectable(Common::String::format("%-3d", i + 1).c_str(), isSelected, ImGuiSelectableFlags_SpanAllColumns)) {
 					if (isSelected) {
 						_state->_selectedChannel = -1;
-						g_director->getCurrentWindow()->render(true);
 					 } else {
 						_state->_selectedChannel = i + 1;
 					 }
+
+					g_director->getCurrentWindow()->render(true);
 				}
 
 				ImGui::TableNextColumn();


Commit: 3f075386a89ce3bac0f99e8f67d1fbdfd96a3795
    https://github.com/scummvm/scummvm/commit/3f075386a89ce3bac0f99e8f67d1fbdfd96a3795
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2025-09-03T21:16:09+02:00

Commit Message:
DIRECTOR: Redraw frame on 'draw' debug command

This ensures we are removing residual artefacts

Changed paths:
    engines/director/debugger.cpp


diff --git a/engines/director/debugger.cpp b/engines/director/debugger.cpp
index 134335863d5..5fab3d84468 100644
--- a/engines/director/debugger.cpp
+++ b/engines/director/debugger.cpp
@@ -987,6 +987,8 @@ bool Debugger::cmdBpList(int argc, const char **argv) {
 
 bool Debugger::cmdDraw(int argc, const char **argv) {
 	if (argc > 1) {
+		int prevDraw = g_director->_debugDraw;
+
 		for (int i = 1; i < argc; i++) {
 			if (!scumm_stricmp(argv[i], "off")) {
 				g_director->_debugDraw = 0;
@@ -1001,6 +1003,10 @@ bool Debugger::cmdDraw(int argc, const char **argv) {
 				return true;
 			}
 		}
+
+		if (prevDraw != g_director->_debugDraw) {
+			g_director->getCurrentWindow()->render(true);
+		}
 	}
 
 	debugPrintf("Draw: ");




More information about the Scummvm-git-logs mailing list