[Scummvm-git-logs] scummvm master -> 2c061673ef3aab32c20e88a6ad249756588bfe08

bluegr noreply at scummvm.org
Sun Sep 14 16:58:50 UTC 2025


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
2c061673ef AGI: fix display method for RTL languages and update kq1 Hebrew entry


Commit: 2c061673ef3aab32c20e88a6ad249756588bfe08
    https://github.com/scummvm/scummvm/commit/2c061673ef3aab32c20e88a6ad249756588bfe08
Author: SegMash (mashras77 at gmail.com)
Date: 2025-09-14T19:58:47+03:00

Commit Message:
AGI: fix display method for RTL languages and update kq1 Hebrew entry

- Fix display method for RTL languages, by aligning to the left by textColumn and text length
- Update the Hebrew fan made version of KQ1, due to small fixes

Changed paths:
    engines/agi/detection_tables.h
    engines/agi/text.cpp


diff --git a/engines/agi/detection_tables.h b/engines/agi/detection_tables.h
index e77dab7af62..50d641f2679 100644
--- a/engines/agi/detection_tables.h
+++ b/engines/agi/detection_tables.h
@@ -379,9 +379,9 @@ static const AGIGameDescription gameDescriptions[] = {
 	// King's Quest 1 (Russian)
 	GAME_LPS("kq1", "", "973f5830ed5e1c919354dfbcd5036c53", 315, Common::RU_RUS, 0x2440, GID_KQ1, Common::kPlatformDOS),
 
-	// King's Quest 1 (Hebrew)
+	// King's Quest 1 (Hebrew) [DOS 2.0F 1987]
 	// Fan made translation by SegMash, based on the English GoG version
-	GAME_LVFPN("kq1", "", "logdir", "9812020c1ff9b86b97976c3e85e29ec8", 315, Common::HE_ISR, 0x2917, GF_EXTCHAR, GID_KQ1, Common::kPlatformDOS, GType_V2, GAMEOPTIONS_DEFAULT),
+	GAME_LVFPN("kq1", "", "logdir", "cf421deebd7378ea35cddc3e7725b68f", 315, Common::HE_ISR, 0x2917, GF_EXTCHAR, GID_KQ1, Common::kPlatformDOS, GType_V2, GAMEOPTIONS_DEFAULT),
 
 	// King's Quest 2 (Apple II) 1.0G [AGI 1.08]
 	A2("kq2", "1.0G", "8e8d562e50233c939112c89bba55d249", 0x1120, GID_KQ2),
diff --git a/engines/agi/text.cpp b/engines/agi/text.cpp
index bb047f5e44b..3d102fbfc94 100644
--- a/engines/agi/text.cpp
+++ b/engines/agi/text.cpp
@@ -246,6 +246,12 @@ void TextMgr::display(int16 textNr, int16 textRow, int16 textColumn) {
 
 	if (textNr >= 1 && textNr <= _vm->_game._curLogic->numTexts) {
 		logicTextPtr = _vm->_game._curLogic->texts[textNr - 1];
+		// For RTL languages, adjust the cursor position to right-align text
+		if (_vm->isLanguageRTL() && logicTextPtr) {
+			int textLength = strlen(logicTextPtr);
+			textColumn = MAX < int16>(0, 40 - textColumn - textLength);
+			charPos_Set(textRow, textColumn);
+		}
 		processedTextPtr = stringPrintf(logicTextPtr);
 		processedTextPtr = stringWordWrap(processedTextPtr, 40);
 




More information about the Scummvm-git-logs mailing list