[Scummvm-git-logs] scummvm master -> 2232738fe85abaf82ccb3674f914e563e7cbcc95

[sluicebox]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
b32de0f395 SCI: Remove unused error check. PVS-Studio V547
2232738fe8 SCI: Remove unused declaration


Commit: b32de0f395df58da1929b45c1d6530578c496a72
    https://github.com/scummvm/scummvm/commit/b32de0f395df58da1929b45c1d6530578c496a72
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2025-09-15T12:35:15-07:00

Commit Message:
SCI: Remove unused error check. PVS-Studio V547

Changed paths:
    engines/sci/engine/kernel.cpp


diff --git a/engines/sci/engine/kernel.cpp b/engines/sci/engine/kernel.cpp
index 49dc9f4db3b..89046fb5b1a 100644
--- a/engines/sci/engine/kernel.cpp
+++ b/engines/sci/engine/kernel.cpp
@@ -418,7 +418,8 @@ uint16 Kernel::findRegType(reg_t reg) {
 		result |= SIG_TYPE_NODE;
 		break;
 	default:
-		return SIG_TYPE_ERROR;
+		result = SIG_TYPE_ERROR;
+		break;
 	}
 	return result;
 }
@@ -473,11 +474,8 @@ void Kernel::signatureDebug(Common::String &signatureDetailsStr, const uint16 *s
 		if (argc) {
 			reg_t parameter = *argv;
 			signatureDetailsStr += signatureDetailsStr.format("%04x:%04x (", PRINT_REG(parameter));
-			int regType = findRegType(parameter);
-			if (regType)
-				kernelSignatureDebugType(signatureDetailsStr, regType);
-			else
-				signatureDetailsStr += signatureDetailsStr.format("unknown type of %04x:%04x", PRINT_REG(parameter));
+			uint16 regType = findRegType(parameter);
+			kernelSignatureDebugType(signatureDetailsStr, regType);
 			signatureDetailsStr += ")";
 			argv++;
 			argc--;


Commit: 2232738fe85abaf82ccb3674f914e563e7cbcc95
    https://github.com/scummvm/scummvm/commit/2232738fe85abaf82ccb3674f914e563e7cbcc95
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2025-09-15T12:35:15-07:00

Commit Message:
SCI: Remove unused declaration

Changed paths:
    engines/sci/sound/drivers/mididriver.h


diff --git a/engines/sci/sound/drivers/mididriver.h b/engines/sci/sound/drivers/mididriver.h
index fb126b5bb47..1392f7c2e24 100644
--- a/engines/sci/sound/drivers/mididriver.h
+++ b/engines/sci/sound/drivers/mididriver.h
@@ -144,7 +144,6 @@ extern MidiPlayer *MidiPlayer_AmigaMac1_create(SciVersion version, Common::Platf
 extern MidiPlayer *MidiPlayer_PCJr_create(SciVersion version);
 extern MidiPlayer *MidiPlayer_PCSpeaker_create(SciVersion version);
 extern MidiPlayer *MidiPlayer_CMS_create(SciVersion version);
-extern MidiPlayer *MidiPlayer_MacSci0_create(SciVersion version);
 extern MidiPlayer *MidiPlayer_Midi_create(SciVersion version);
 extern MidiPlayer *MidiPlayer_Fb01_create(SciVersion version);
 extern MidiPlayer *MidiPlayer_Casio_create(SciVersion version, MusicType midiType);