[Scummvm-git-logs] scummvm master -> 99034b69b0163ae8ca6eb712f8a15d3054ede040

mduggan noreply at scummvm.org
Fri Sep 26 12:00:09 UTC 2025


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
99034b69b0 ACCESS: Make virtual calls in const/destructors explicit (PVS-Studio V1053)


Commit: 99034b69b0163ae8ca6eb712f8a15d3054ede040
    https://github.com/scummvm/scummvm/commit/99034b69b0163ae8ca6eb712f8a15d3054ede040
Author: Matthew Duggan (mgithub at guarana.org)
Date: 2025-09-26T22:00:01+10:00

Commit Message:
ACCESS: Make virtual calls in const/destructors explicit (PVS-Studio V1053)

Changed paths:
    engines/access/asurface.cpp
    engines/access/screen.cpp
    engines/access/video/movie_decoder.cpp


diff --git a/engines/access/asurface.cpp b/engines/access/asurface.cpp
index 3224b82bef4..4420be87fe7 100644
--- a/engines/access/asurface.cpp
+++ b/engines/access/asurface.cpp
@@ -61,7 +61,7 @@ SpriteFrame::SpriteFrame(const AccessEngine *vm, Common::SeekableReadStream *str
 		if (size != frameSize)
 			warning("Unexpected file difference: framesize %d - size %d %d - unknown %d", frameSize, xSize, ySize, size);
 	}
-	create(xSize, ySize);
+	Graphics::Screen::create(xSize, ySize);
 
 	// Empty surface
 	byte *data = (byte *)getPixels();
@@ -79,7 +79,7 @@ SpriteFrame::SpriteFrame(const AccessEngine *vm, Common::SeekableReadStream *str
 }
 
 SpriteFrame::~SpriteFrame() {
-	free();
+	Graphics::Screen::free();
 }
 
 /*------------------------------------------------------------------------*/
@@ -111,7 +111,7 @@ int BaseSurface::_lastBoundsW;
 int BaseSurface::_lastBoundsH;
 
 BaseSurface::BaseSurface(): Graphics::Screen(0, 0) {
-	free();		// Free the 0x0 surface allocated by Graphics::Screen
+	Graphics::Screen::free();		// Free the 0x0 surface allocated by Graphics::Screen
 	_leftSkip = _rightSkip = 0;
 	_topSkip = _bottomSkip = 0;
 	_orgX1 = _orgY1 = 0;
diff --git a/engines/access/screen.cpp b/engines/access/screen.cpp
index 139200ba5ce..b12e3b451b0 100644
--- a/engines/access/screen.cpp
+++ b/engines/access/screen.cpp
@@ -48,7 +48,7 @@ ScreenSave::ScreenSave() : _clipWidth(0), _clipHeight(0), _windowXAdd(0), _windo
 }
 
 Screen::Screen(AccessEngine *vm) : _vm(vm) {
-	create(320, 200);
+	Graphics::Screen::create(320, 200);
 	Common::fill(&_tempPalette[0], &_tempPalette[Graphics::PALETTE_SIZE], 0);
 	Common::fill(&_manPal[0], &_manPal[0x60], 0);
 	Common::fill(&_scaleTable1[0], &_scaleTable1[256], 0);
diff --git a/engines/access/video/movie_decoder.cpp b/engines/access/video/movie_decoder.cpp
index a9e470cad70..cdf96f33478 100644
--- a/engines/access/video/movie_decoder.cpp
+++ b/engines/access/video/movie_decoder.cpp
@@ -49,7 +49,7 @@ AccessVIDMovieDecoder::AccessVIDMovieDecoder()
 }
 
 AccessVIDMovieDecoder::~AccessVIDMovieDecoder() {
-	close();
+	AccessVIDMovieDecoder::close();
 }
 
 bool AccessVIDMovieDecoder::loadStream(Common::SeekableReadStream *stream) {




More information about the Scummvm-git-logs mailing list