[Scummvm-git-logs] scummvm master -> f8174b7681d8b5e7fcb43cae0236cf1a5c62434c

[mduggan]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
f8174b7681 ACCESS: Fix ambiguous sequence of operations (PVS-Studio V567)


Commit: f8174b7681d8b5e7fcb43cae0236cf1a5c62434c
    https://github.com/scummvm/scummvm/commit/f8174b7681d8b5e7fcb43cae0236cf1a5c62434c
Author: Matthew Duggan (mgithub at guarana.org)
Date: 2025-09-29T20:19:13+10:00

Commit Message:
ACCESS: Fix ambiguous sequence of operations (PVS-Studio V567)

In practice we don't use this code because we use scummvm file boxes, but if we
ever add original save dialog support it could become important.

Changed paths:
    engines/access/bubble_box.cpp


diff --git a/engines/access/bubble_box.cpp b/engines/access/bubble_box.cpp
index 749fbb7a46b..3f18d73de93 100644
--- a/engines/access/bubble_box.cpp
+++ b/engines/access/bubble_box.cpp
@@ -128,8 +128,9 @@ void BubbleBox::calcBubble(const Common::String &msg) {
 		bounds.setWidth((_vm->_fonts._printMaxX / 16 + 2) * 16 + 2 + 1);
 		bounds.bottom = screen._printOrg.y + 4 + 1;
 	} else {
+		// TODO: Check this maths if we implement original file boxes.
 		if (_type == kBoxTypeFileDialog)
-			(++screen._printOrg.y) += 6;
+			screen._printOrg.y += 6;
 
 		// Determine the width for the area
 		width = (((_vm->_fonts._printMaxX >> 4) + 1) << 4) + 5;