[Scummvm-git-logs] scummvm master -> e89cf4bf82505d4705b801a58b73787bbefadd75

[dreammaster]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
e89cf4bf82 BAGEL: MINIGAMES: Fix Archeroids Coverity warnings


Commit: e89cf4bf82505d4705b801a58b73787bbefadd75
    https://github.com/scummvm/scummvm/commit/e89cf4bf82505d4705b801a58b73787bbefadd75
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2025-09-30T03:16:00-07:00

Commit Message:
BAGEL: MINIGAMES: Fix Archeroids Coverity warnings

Changed paths:
    engines/bagel/hodjnpodj/archeroids/main.cpp
    engines/bagel/hodjnpodj/archeroids/usercfg.h


diff --git a/engines/bagel/hodjnpodj/archeroids/main.cpp b/engines/bagel/hodjnpodj/archeroids/main.cpp
index b105256f106..3eb68cbb727 100644
--- a/engines/bagel/hodjnpodj/archeroids/main.cpp
+++ b/engines/bagel/hodjnpodj/archeroids/main.cpp
@@ -1451,6 +1451,8 @@ POINT CMainWindow::GetLeftMostBadGuy() {
 	assert(m_pBadGuyList != nullptr);
 
 	ptBest.x = 9999;
+	ptBest.y = 0;
+
 	pList = m_pBadGuyList->getHead();
 	while (pList != nullptr) {
 		ptTmp = ((CSprite *)pList->getData())->GetPosition();
@@ -2787,8 +2789,7 @@ void CMainWindow::DestroyBadGuy(CLList *pList, CDC *pDC) {
 				m_pFXList->Insert(pNewList);
 		}
 
-	} else {
-
+	} else if (pNewSprite) {
 		KillAnimation();
 
 		//
diff --git a/engines/bagel/hodjnpodj/archeroids/usercfg.h b/engines/bagel/hodjnpodj/archeroids/usercfg.h
index 1037345f146..b2bfc364599 100644
--- a/engines/bagel/hodjnpodj/archeroids/usercfg.h
+++ b/engines/bagel/hodjnpodj/archeroids/usercfg.h
@@ -50,11 +50,9 @@ namespace Archeroids {
 
 class CUserCfgDlg : public CBmpDialog {
 public:
-
 	CUserCfgDlg(CWnd *, CPalette *, unsigned int);
 
 protected:
-
 	virtual bool OnCommand(WPARAM, LPARAM) override;
 	virtual bool OnInitDialog() override;
 	void PutDlgData();
@@ -68,15 +66,15 @@ protected:
 	//
 	// user preference data
 	//
-	CText       *m_pTxtSpeed;
-	CText       *m_pTxtSpeedSetting;
-	CText       *m_pTxtLevel;
-	CText       *m_pTxtLives;
-	int          m_nInitGameSpeed;
-	int          m_nInitArcherLevel;
-	int          m_nInitNumLives;
-	int          m_nInitNumBadGuys;
-	bool         m_bShouldSave;           // True if we should save theses settings
+	CText       *m_pTxtSpeed = nullptr;
+	CText       *m_pTxtSpeedSetting = nullptr;
+	CText       *m_pTxtLevel = nullptr;
+	CText       *m_pTxtLives = nullptr;
+	int          m_nInitGameSpeed = 0;
+	int          m_nInitArcherLevel = 0;
+	int          m_nInitNumLives = 0;
+	int          m_nInitNumBadGuys = 0;
+	bool         m_bShouldSave = false;           // True if we should save theses settings
 };
 
 } // namespace Archeroids