[Scummvm-git-logs] scummvm master -> 88095a5504c18b20ba913e7e6e1a1d5ff894cc14

dreammaster noreply at scummvm.org
Tue Sep 30 11:23:50 UTC 2025


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
88095a5504 BAGEL: MINIGAMES: Fix Crypt Coverity warnings


Commit: 88095a5504c18b20ba913e7e6e1a1d5ff894cc14
    https://github.com/scummvm/scummvm/commit/88095a5504c18b20ba913e7e6e1a1d5ff894cc14
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2025-09-30T04:23:37-07:00

Commit Message:
BAGEL: MINIGAMES: Fix Crypt Coverity warnings

Changed paths:
    engines/bagel/hodjnpodj/crypt/main.cpp
    engines/bagel/hodjnpodj/crypt/pnt_gram.cpp


diff --git a/engines/bagel/hodjnpodj/crypt/main.cpp b/engines/bagel/hodjnpodj/crypt/main.cpp
index 4a159e52874..e3ab0744991 100644
--- a/engines/bagel/hodjnpodj/crypt/main.cpp
+++ b/engines/bagel/hodjnpodj/crypt/main.cpp
@@ -852,10 +852,10 @@ void CMainWindow::OnLButtonDown(unsigned int nFlags, CPoint point) {
 				Sleep(URN1_SLEEP);
 			}
 		}
-		if (pSprite != nullptr)
-			delete pSprite;
 
+		delete pSprite;
 		ReleaseDC(pDC);
+
 	} else if (urn2Rect.PtInRect(point)) {
 		pDC = GetDC();
 		pSprite = new CSprite;
diff --git a/engines/bagel/hodjnpodj/crypt/pnt_gram.cpp b/engines/bagel/hodjnpodj/crypt/pnt_gram.cpp
index cb15dcfb145..3688d483944 100644
--- a/engines/bagel/hodjnpodj/crypt/pnt_gram.cpp
+++ b/engines/bagel/hodjnpodj/crypt/pnt_gram.cpp
@@ -1181,6 +1181,8 @@ void CPaintGram::ReplaceLetter(CDC *pDC, int nOldType, int nNewType) {
 			delete m_cDisplayLetters;
 
 			nIndexCode = CharToIndex(nNewType);
+			assert(nIndexCode < REVEAL_SYMBOLS);
+
 			if (IsRevealType(nNewType) == true) {
 				m_cDisplayLetters = (*m_cRevealAlphabet[nIndexCode]).DuplicateSprite(pDC);  // setup new sprite
 			} else if (IsUsedType(nNewType) == true) {




More information about the Scummvm-git-logs mailing list