[Scummvm-git-logs] scummvm master -> 99e6e14f8411a707d86e15cb745b6cee003761d5
sev-
noreply at scummvm.org
Wed Apr 15 20:40:12 UTC 2026
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .
Summary:
99e6e14f84 DIRECTOR: DT: fix minor score bugs
Commit: 99e6e14f8411a707d86e15cb745b6cee003761d5
https://github.com/scummvm/scummvm/commit/99e6e14f8411a707d86e15cb745b6cee003761d5
Author: ramyak-sharma (ramyaksharma1 at gmail.com)
Date: 2026-04-16T01:05:46+05:30
Commit Message:
DIRECTOR: DT: fix minor score bugs
Changed paths:
engines/director/debugger/debugtools.cpp
engines/director/debugger/dt-score.cpp
diff --git a/engines/director/debugger/debugtools.cpp b/engines/director/debugger/debugtools.cpp
index ed093b5baad..ce8a089aff6 100644
--- a/engines/director/debugger/debugtools.cpp
+++ b/engines/director/debugger/debugtools.cpp
@@ -835,14 +835,7 @@ void onImGuiRender() {
return;
if (_state->_windowToRedraw) {
- Graphics::ManagedSurface *surface = _state->_windowToRedraw->getSurface();
- if (surface) {
- Common::Rect fullScreen(0, 0, surface->w, surface->h);
-
- _state->_windowToRedraw->addDirtyRect(fullScreen);
- _state->_windowToRedraw->setDirty(true);
- }
-
+ _state->_windowToRedraw->render(true);
_state->_windowToRedraw = nullptr;
}
diff --git a/engines/director/debugger/dt-score.cpp b/engines/director/debugger/dt-score.cpp
index 3e0901fefc4..831864766b4 100644
--- a/engines/director/debugger/dt-score.cpp
+++ b/engines/director/debugger/dt-score.cpp
@@ -269,7 +269,7 @@ static void drawSidebar1(ImDrawList *dl, ImVec2 startPos, Score *score) {
}
}
-static void drawSidebar2(ImDrawList *dl, ImVec2 startPos, Score *score) {
+static void drawSidebar2(ImDrawList *dl, ImVec2 startPos, Score *score, Window *window) {
float toggleColWidth = 20.0f;
float labelColWidth = 40.0f;
float totalWidth = toggleColWidth + labelColWidth;
@@ -318,6 +318,7 @@ static void drawSidebar2(ImDrawList *dl, ImVec2 startPos, Score *score) {
setTooltip("Playback toggle");
if (ImGui::IsItemClicked()) { // determines what happens on toggle of the button
score->_channels[ch]->_hideFromStage = !isHiddenFromStage;
+ _state->_windowToRedraw = window;
}
// channel num and extra stuff if extended mode
@@ -742,9 +743,18 @@ static void drawSpriteGrid(ImDrawList *dl, ImVec2 startPos, Score *score, Cast *
_state->_selectedScoreCast.channel = ch;
_state->_selectedScoreCast.isMainChannel = false;
+ // Open cast member details window
+ if (sprite._castId.member) {
+ CastMember *clickedCM = cast->getCastMember(sprite._castId.member, true);
+ if (clickedCM) {
+ _state->_castDetails._castMember = clickedCM;
+ _state->_w.castDetails = true;
+ }
+ }
+
int playheadIdx = score->getCurrentFrameNum() - 1;
if (playheadIdx >= spanStart && playheadIdx <= spanEnd) {
- Director::DT::setSelectedChannel(ch);
+ _state->_selectedChannel = ch;
_state->_windowToRedraw = window;
}
}
@@ -1163,7 +1173,7 @@ void showScore() {
drawMainChannelGrid(dl, layout.mainChannelGridPos, score);
drawModeSelector(layout.modeSelectorPos);
drawRuler(dl, layout.rulerPos);
- drawSidebar2(dl, layout.sidebar2Pos, score);
+ drawSidebar2(dl, layout.sidebar2Pos, score, selectedWindow);
drawSpriteGrid(dl, layout.gridPos, score, cast, selectedWindow);
drawPlayhead(dl, layout.rulerPos, layout.mainChannelGridPos, layout.gridPos, score);
drawSliderX(layout.sliderPos, score);
More information about the Scummvm-git-logs
mailing list