[Scummvm-git-logs] scummvm master -> a98e2fd5123da80fc5d955a80b5d99564b67e6db

[lephilousophe]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
a98e2fd512 GUI: Avoid useless checks in MetadataParser


Commit: a98e2fd5123da80fc5d955a80b5d99564b67e6db
    https://github.com/scummvm/scummvm/commit/a98e2fd5123da80fc5d955a80b5d99564b67e6db
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2026-04-18T23:35:13+02:00

Commit Message:
GUI: Avoid useless checks in MetadataParser

Don't check the node name once we found a match.

Changed paths:
    gui/MetadataParser.cpp


diff --git a/gui/MetadataParser.cpp b/gui/MetadataParser.cpp
index b38265d9079..8bbecfc2092 100644
--- a/gui/MetadataParser.cpp
+++ b/gui/MetadataParser.cpp
@@ -68,19 +68,19 @@ bool MetadataParser::parserCallback_company(ParserNode *node) {
 }
 
 bool MetadataParser::closedKeyCallback(ParserNode *node) {
-	if (node->name == "game")
+	if (node->name == "game") {
 		_gameInfo[Common::String::format("%s:%s",
 			node->values["engine_id"].c_str(), node->values["id"].c_str())] = MetadataGame(
 			node->values["id"], node->values["name"], node->values["engine_id"], node->values["company_id"],
 			node->values["moby_id"], node->values["datafiles"], node->values["series_id"], node->values["zoom_id"], node->values["year"]);
-
-	if (node->name == "engine")
+	} else if (node->name == "engine") {
 		_engineInfo[node->values["id"]] = MetadataEngine(node->values["id"], node->values["name"], node->values["alt_name"],
 											true);
-	if (node->name == "serie")
+	} else if (node->name == "serie") {
 		_seriesInfo[node->values["id"]] = MetadataSeries(node->values["id"], node->values["name"]);
-	if (node->name == "company")
+	} else if (node->name == "company") {
 		_companyInfo[node->values["id"]] = MetadataCompany(node->values["id"], node->values["name"], node->values["alt_name"]);
+	}
 	return true;
 }