[Scummvm-git-logs] scummvm master -> 1e9b1a1618bbf0e72e351b83d5fed850d7ea0a23

dreammaster noreply at scummvm.org
Mon Apr 20 11:20:41 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
1e9b1a1618 MADS: PHANTOM: Make buffer_legal call param a const Buffer &


Commit: 1e9b1a1618bbf0e72e351b83d5fed850d7ea0a23
    https://github.com/scummvm/scummvm/commit/1e9b1a1618bbf0e72e351b83d5fed850d7ea0a23
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2026-04-20T21:20:23+10:00

Commit Message:
MADS: PHANTOM: Make buffer_legal call param a const Buffer &

Changed paths:
    engines/mads/madsv2/core/buffer.cpp
    engines/mads/madsv2/core/buffer.h


diff --git a/engines/mads/madsv2/core/buffer.cpp b/engines/mads/madsv2/core/buffer.cpp
index 3da3fa7e3b0..3ba248cf189 100644
--- a/engines/mads/madsv2/core/buffer.cpp
+++ b/engines/mads/madsv2/core/buffer.cpp
@@ -387,8 +387,8 @@ void buffer_line_xor(Buffer target, int x1, int y1, int x2, int y2) {
 	}
 }
 
-int buffer_legal(Buffer walk, int orig_wrap,
-	int x1, int y1, int x2, int y2) {
+int buffer_legal(const Buffer &walk, int orig_wrap,
+		int x1, int y1, int x2, int y2) {
 	word legality = LEGAL;
 	word currently_illegal = false;
 
diff --git a/engines/mads/madsv2/core/buffer.h b/engines/mads/madsv2/core/buffer.h
index 6b5e4b57876..fabb355925a 100644
--- a/engines/mads/madsv2/core/buffer.h
+++ b/engines/mads/madsv2/core/buffer.h
@@ -220,7 +220,7 @@ extern void buffer_line_xor(Buffer target, int x1, int y1, int x2, int y2);
  * bounds checking is performed first: a NULL buffer or any coordinate outside
  * the buffer dimensions short-circuits to LEGAL without scanning.
  */
-extern int buffer_legal(Buffer walk, int orig_wrap, int x1, int y1, int x2, int y2);
+extern int buffer_legal(const Buffer &walk, int orig_wrap, int x1, int y1, int x2, int y2);
 
 word buffer_rect_fill_pattern(Buffer target, int ul_x, int ul_y, int size_x, int size_y,
 	int base_x, int base_y, int base_xs, byte value1, byte value2,




More information about the Scummvm-git-logs mailing list