[Scummvm-git-logs] scummvm master -> 4cba50c7bf6c42f1a5ec7d4521d404bb687c5709

digitall noreply at scummvm.org
Fri Apr 24 01:16:10 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
4cba50c7bf MADS: PHANTOM: Fix Various GCC Compiler Warnings


Commit: 4cba50c7bf6c42f1a5ec7d4521d404bb687c5709
    https://github.com/scummvm/scummvm/commit/4cba50c7bf6c42f1a5ec7d4521d404bb687c5709
Author: D G Turner (digitall at scummvm.org)
Date: 2026-04-24T02:15:25+01:00

Commit Message:
MADS: PHANTOM: Fix Various GCC Compiler Warnings

Changed paths:
    engines/mads/madsv2/core/anim.cpp
    engines/mads/madsv2/core/config.cpp
    engines/mads/madsv2/core/config.h
    engines/mads/madsv2/core/copy.cpp
    engines/mads/madsv2/core/cycle.cpp
    engines/mads/madsv2/core/dialog.cpp


diff --git a/engines/mads/madsv2/core/anim.cpp b/engines/mads/madsv2/core/anim.cpp
index 411510420de..81fb77d7c97 100644
--- a/engines/mads/madsv2/core/anim.cpp
+++ b/engines/mads/madsv2/core/anim.cpp
@@ -40,7 +40,7 @@
 namespace MADS {
 namespace MADSV2 {
 
-ShadowList anim_shadow = { 0 };
+ShadowList anim_shadow = { 0, { 0, 0, 0 } };
 int anim_error;
 
 void AnimFile::load(Common::SeekableReadStream *src) {
diff --git a/engines/mads/madsv2/core/config.cpp b/engines/mads/madsv2/core/config.cpp
index 36f7c371d30..dc7f79b6531 100644
--- a/engines/mads/madsv2/core/config.cpp
+++ b/engines/mads/madsv2/core/config.cpp
@@ -36,7 +36,9 @@ ConfigFile config_file = { 0, 0x220,
 			   0, true,
 			   0, 0,
 			   false, 'D',
-			   false };
+			   false,
+			   false,
+			   7, 0, 0, 0, 0 };
 
 void read_config_file() {
 	ConfMan.registerDefault("music_mute", false);
diff --git a/engines/mads/madsv2/core/config.h b/engines/mads/madsv2/core/config.h
index 9eaf604c513..aff8469f3ec 100644
--- a/engines/mads/madsv2/core/config.h
+++ b/engines/mads/madsv2/core/config.h
@@ -109,8 +109,8 @@ extern ConfigFile config_file;
 
 extern void read_config_file();
 extern void write_config_file();
-extern void global_load_config_parameters();
-extern void global_unload_config_parameters();
+//extern void global_load_config_parameters();
+//extern void global_unload_config_parameters();
 
 } // namespace MADSV2
 } // namespace MADS
diff --git a/engines/mads/madsv2/core/copy.cpp b/engines/mads/madsv2/core/copy.cpp
index 83cbe2ac799..f6d01bb4372 100644
--- a/engines/mads/madsv2/core/copy.cpp
+++ b/engines/mads/madsv2/core/copy.cpp
@@ -52,7 +52,7 @@ static void copy_mangle(CopyProt *copy_prot) {
 
 	dog = (byte *)copy_prot;
 
-	for (count = 0; count < sizeof(CopyProt); count++) {
+	for (count = 0; count < (int)sizeof(CopyProt); count++) {
 		*dog ^= 0xff;
 		dog++;
 	}
diff --git a/engines/mads/madsv2/core/cycle.cpp b/engines/mads/madsv2/core/cycle.cpp
index 509a65d1b2b..c8c4b3fe651 100644
--- a/engines/mads/madsv2/core/cycle.cpp
+++ b/engines/mads/madsv2/core/cycle.cpp
@@ -38,7 +38,7 @@ int cycling_threshold;
 int total_cycle_colors;
 
 long cycle_timing[COLOR_MAX_CYCLES];
-static RGBcolor temp_color;
+//static RGBcolor temp_color;
 
 void cycle_init(CycleListPtr new_cycle_list, int activate) {
 	int count;
diff --git a/engines/mads/madsv2/core/dialog.cpp b/engines/mads/madsv2/core/dialog.cpp
index f8ba367f1d6..8e8c26abb74 100644
--- a/engines/mads/madsv2/core/dialog.cpp
+++ b/engines/mads/madsv2/core/dialog.cpp
@@ -2197,14 +2197,14 @@ static void dialog_do_search(DialogPtr dialog, ItemPtr item) {
 static void dialog_set_new_directory(DialogPtr dialog, ItemPtr item) {
 	int buf;
 	//int newdrive;
-	ItemPtr baseitem, fileitem, pathitem;
+	ItemPtr baseitem; //, fileitem, pathitem;
 
 	baseitem = &dialog->item[item->status];
-	fileitem = &dialog->item[baseitem->status];
+	//fileitem = &dialog->item[baseitem->status];
 	buf = baseitem->buf_id;
 
 	Common::strcpy_s(temp_buf, dialog->buffer[buf]);
-	pathitem = dialog->path_item;
+	//pathitem = dialog->path_item;
 #ifdef TODO
 	if (temp_buf[1] == ':') {
 		// Change to a new drive, if requested
@@ -2955,7 +2955,7 @@ ItemPtr dialog_execute(DialogPtr dialog, ItemPtr active_item, ItemPtr default_bu
 	int mykey;
 	int count;
 	int buf;
-	int savedpath;
+	//int savedpath;
 	int savedrive = 0;
 	int return_code;
 	char savepath[80];
@@ -2977,7 +2977,7 @@ ItemPtr dialog_execute(DialogPtr dialog, ItemPtr active_item, ItemPtr default_bu
 	}
 
 	if (dialog->status & DD_FILEMENU) {
-		savedpath = (mads_getcwd(savepath, 80) != NULL);
+		//savedpath = (mads_getcwd(savepath, 80) != NULL);
 		savedrive = mads_getdrive();
 
 		if (dialog->path_item != NULL) {




More information about the Scummvm-git-logs mailing list