[Scummvm-git-logs] scummvm master -> 59316d925164c94a1d869366a78352d3884ca303

[dreammaster]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
59316d9251 MADS: Coverity warning fixes


Commit: 59316d925164c94a1d869366a78352d3884ca303
    https://github.com/scummvm/scummvm/commit/59316d925164c94a1d869366a78352d3884ca303
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2026-08-01T12:26:32+10:00

Commit Message:
MADS: Coverity warning fixes

Changed paths:
    engines/mads/core/magic.cpp
    engines/mads/core/mps_installer.cpp
    engines/mads/core/player.cpp


diff --git a/engines/mads/core/magic.cpp b/engines/mads/core/magic.cpp
index c3326986277..ddd918e9dbd 100644
--- a/engines/mads/core/magic.cpp
+++ b/engines/mads/core/magic.cpp
@@ -395,8 +395,8 @@ void magic_screen_change_corner(Buffer *new_screen, Palette pal,
 	int delta_x, delta_y;
 	int size_x, size_y;
 	int at_x, at_y;
-	int *vx = NULL;
-	int *hy = NULL;
+	int *vx;
+	int *hy;
 	int accum;
 	int loop, count;
 	int loop_start;
@@ -425,6 +425,7 @@ void magic_screen_change_corner(Buffer *new_screen, Palette pal,
 		vx = &x2;
 		break;
 	case MAGIC_UPPER_RIGHT:
+	default:
 		start_x = x - 1;
 		hy = &y2;
 		vx = &x1;
diff --git a/engines/mads/core/mps_installer.cpp b/engines/mads/core/mps_installer.cpp
index bab7434a7b2..60c7170e827 100644
--- a/engines/mads/core/mps_installer.cpp
+++ b/engines/mads/core/mps_installer.cpp
@@ -117,8 +117,7 @@ Common::SharedArchiveContents MpsInstaller::readContentsForPath(const Common::Pa
 
 		rem -= actual;
 		outptr += actual;
-		if (actual == 0)
-			break;
+
 		vol++;
 		off = 0;
 	}
diff --git a/engines/mads/core/player.cpp b/engines/mads/core/player.cpp
index 2ce4bc6131a..5d121ac34f0 100644
--- a/engines/mads/core/player.cpp
+++ b/engines/mads/core/player.cpp
@@ -809,6 +809,7 @@ int player_parse(int vocab_item, ...) {
 
 		my_word = va_arg(marker, int);
 	}
+	va_end(marker);
 
 done:
 	return result;