[Scummvm-git-logs] scummvm master -> 50407e3e56a78be0bb2e7f086892300dff4c5c88
dreammaster
noreply at scummvm.org
Wed Aug 5 06:43:02 UTC 2026
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .
Summary:
50407e3e56 MADS: NEBULAR: Animview doesn't play back speech sounds
Commit: 50407e3e56a78be0bb2e7f086892300dff4c5c88
https://github.com/scummvm/scummvm/commit/50407e3e56a78be0bb2e7f086892300dff4c5c88
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2026-08-05T16:42:49+10:00
Commit Message:
MADS: NEBULAR: Animview doesn't play back speech sounds
This was added in Phantom, and not in Rex Nebular.
Pointed out by Tropp
Changed paths:
engines/mads/animview/anim_timer.cpp
diff --git a/engines/mads/animview/anim_timer.cpp b/engines/mads/animview/anim_timer.cpp
index 5bd7cdf2793..70f8acfc19e 100644
--- a/engines/mads/animview/anim_timer.cpp
+++ b/engines/mads/animview/anim_timer.cpp
@@ -117,9 +117,13 @@ void anim_timer() {
speech->display_condition != 0x800 &&
speech->resource_id >= 0;
- if (speech->sound /*&& (!flag || sound_var1 == '1')*/) {
- g_engine->_soundManager->command(speech->sound);
- flag = false;
+ if (g_engine->getGameID() != GType_RexNebular) {
+ // In Phantom sound_dma is one of the sound card params which can be configurable via flags.
+ // But since it's default is already '1', hence we can disable that part of the if check
+ if (speech->sound /*&& (!flag || sound_dma == '1')*/) {
+ g_engine->_soundManager->command(speech->sound);
+ flag = false;
+ }
}
if (flag) {
More information about the Scummvm-git-logs
mailing list