[Scummvm-git-logs] scummvm master -> ab67429530a9325ad8fe4c6c43f77e23d9c5096e

[mikrosk]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
334a9a81bf GUI: Show <default> for an unset AdLib emulator
ab67429530 BACKENDS: ATARI: Add a note about OPL


Commit: 334a9a81bfaa1b6e6db60b705eef8b50928a4ced
    https://github.com/scummvm/scummvm/commit/334a9a81bfaa1b6e6db60b705eef8b50928a4ced
Author: Miro Kropacek (miro.kropacek at gmail.com)
Date: 2026-08-17T22:53:12+10:00

Commit Message:
GUI: Show <default> for an unset AdLib emulator

An absent opl_driver key parses to -1 which the MAX() clamped to 0,
i.e. kNull - so a fresh configuration displayed "None" while the
default emulator was in fact active. Select the "auto" entry instead.

Fixes #16697.

Changed paths:
    gui/options.cpp


diff --git a/gui/options.cpp b/gui/options.cpp
index bba2cd1af85..8b4872b3703 100644
--- a/gui/options.cpp
+++ b/gui/options.cpp
@@ -487,7 +487,9 @@ void OptionsDialog::build() {
 		_midiPopUp->setSelected(0);
 
 	if (_oplPopUp) {
-		OPL::Config::DriverId id = MAX<OPL::Config::DriverId>(OPL::Config::parse(ConfMan.get("opl_driver", _domain)), 0);
+		OPL::Config::DriverId id = OPL::Config::parse(ConfMan.get("opl_driver", _domain));
+		if (id < 0)
+			id = OPL::Config::parse("auto");
 		_oplPopUp->setSelectedTag(id);
 	}
 


Commit: ab67429530a9325ad8fe4c6c43f77e23d9c5096e
    https://github.com/scummvm/scummvm/commit/ab67429530a9325ad8fe4c6c43f77e23d9c5096e
Author: Miro Kropacek (miro.kropacek at gmail.com)
Date: 2026-08-17T23:00:27+10:00

Commit Message:
BACKENDS: ATARI: Add a note about OPL

For instance in BASS intro, OPL doesn't produce any music and yet it
contributes to how much the audio 'thread' consumes.

Changed paths:
    backends/platform/atari/readme.txt
    backends/platform/atari/readme.txt.in


diff --git a/backends/platform/atari/readme.txt b/backends/platform/atari/readme.txt
index 62acbebe065..2931b9cb076 100644
--- a/backends/platform/atari/readme.txt
+++ b/backends/platform/atari/readme.txt
@@ -369,9 +369,10 @@ other version. With one exception: if you have a native MIDI device able to
 replay the given game's MIDI notes (using the STMIDI plugin).
 
 MIDI emulation (synthesis) can easily eat as much as 50% of all used CPU time
-(on the CT60). By default, this port uses the MAME OPL emulation (which is said
-to be fastest but also least accurate) but some engines require the DOSBOX one
-which is even more demanding. By the way, you can put "FM_high_quality=true" or
+(on the CT60 and even if no OPL music is produced at the moment). By default,
+this port uses the MAME OPL emulation (which is said to be fastest but also
+least accurate) but some engines require the DOSBOX one which is even more
+demanding. By the way, you can put "FM_high_quality=true" or
 "FM_medium_quality=true" into scummvm.ini if you want to experiment with a
 better quality synthesis, otherwise the lowest quality will be used (applies
 for MAME OPL only).
diff --git a/backends/platform/atari/readme.txt.in b/backends/platform/atari/readme.txt.in
index e03e0df79e7..d74fa7cebbd 100644
--- a/backends/platform/atari/readme.txt.in
+++ b/backends/platform/atari/readme.txt.in
@@ -369,9 +369,10 @@ other version. With one exception: if you have a native MIDI device able to
 replay the given game's MIDI notes (using the STMIDI plugin).
 
 MIDI emulation (synthesis) can easily eat as much as 50% of all used CPU time
-(on the CT60). By default, this port uses the MAME OPL emulation (which is said
-to be fastest but also least accurate) but some engines require the DOSBOX one
-which is even more demanding. By the way, you can put "FM_high_quality=true" or
+(on the CT60 and even if no OPL music is produced at the moment). By default,
+this port uses the MAME OPL emulation (which is said to be fastest but also
+least accurate) but some engines require the DOSBOX one which is even more
+demanding. By the way, you can put "FM_high_quality=true" or
 "FM_medium_quality=true" into scummvm.ini if you want to experiment with a
 better quality synthesis, otherwise the lowest quality will be used (applies
 for MAME OPL only).