[Scummvm-git-logs] scummvm master -> c84589ba923657b98d2ae4c7382db979d485d4f0

[sev-]

This automated email contains information about 5 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
fe6cbc1703 ULTIMA: ULTIMA0: Add missing override keywords
4e9cfff162 ULTIMA: ULTIMA0: Comment out unused variable
a351fa9ab0 ULTIMA: ULTIMA0: Add missing come in sting constant list
8c5e4f0866 ULTIMA: ULTIMA0: Comment out unused variable
c84589ba92 ULTIMA: ULTIMA0: Fix warning


Commit: fe6cbc170376f19bc94a35fd128598870753a5e9
    https://github.com/scummvm/scummvm/commit/fe6cbc170376f19bc94a35fd128598870753a5e9
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2026-01-04T11:34:24+01:00

Commit Message:
ULTIMA: ULTIMA0: Add missing override keywords

Changed paths:
    engines/ultima/ultima0/views/attack.h
    engines/ultima/ultima0/views/title.h


diff --git a/engines/ultima/ultima0/views/attack.h b/engines/ultima/ultima0/views/attack.h
index fbc58851c8b..720dbfd1731 100644
--- a/engines/ultima/ultima0/views/attack.h
+++ b/engines/ultima/ultima0/views/attack.h
@@ -56,7 +56,7 @@ public:
 
 	bool msgKeypress(const KeypressMessage &msg) override;
 	bool msgAction(const ActionMessage &msg) override;
-	void timeout();
+	void timeout() override;
 };
 
 } // namespace Views
diff --git a/engines/ultima/ultima0/views/title.h b/engines/ultima/ultima0/views/title.h
index 790213b237f..84156e3e244 100644
--- a/engines/ultima/ultima0/views/title.h
+++ b/engines/ultima/ultima0/views/title.h
@@ -61,7 +61,7 @@ public:
 	void draw() override;
 	bool msgAction(const ActionMessage &msg) override;
 	bool msgGame(const GameMessage &msg) override;
-	bool msgMouseDown(const MouseDownMessage &msg);
+	bool msgMouseDown(const MouseDownMessage &msg) override;
 };
 
 } // namespace Views


Commit: 4e9cfff16251873b86a6762cd9d312f695ec4879
    https://github.com/scummvm/scummvm/commit/4e9cfff16251873b86a6762cd9d312f695ec4879
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2026-01-04T11:36:38+01:00

Commit Message:
ULTIMA: ULTIMA0: Comment out unused variable

Changed paths:
    engines/ultima/ultima0/ultima0.cpp
    engines/ultima/ultima0/ultima0.h


diff --git a/engines/ultima/ultima0/ultima0.cpp b/engines/ultima/ultima0/ultima0.cpp
index c29798eacca..98629917b28 100644
--- a/engines/ultima/ultima0/ultima0.cpp
+++ b/engines/ultima/ultima0/ultima0.cpp
@@ -48,7 +48,7 @@ static const byte PALETTE[][3] = {
 Ultima0Engine *g_engine;
 
 Ultima0Engine::Ultima0Engine(OSystem *syst, const Ultima::UltimaGameDescription *gameDesc) :
-		Engine(syst), _gameDescription(gameDesc), _randomSource("Ultima0"),
+		Engine(syst), /*_gameDescription(gameDesc), */_randomSource("Ultima0"),
 		_palette(&PALETTE[0][0], sizeof(PALETTE) / 3) {
 	g_engine = this;
 }
diff --git a/engines/ultima/ultima0/ultima0.h b/engines/ultima/ultima0/ultima0.h
index 793cb6c1a3f..40cdbb054ad 100644
--- a/engines/ultima/ultima0/ultima0.h
+++ b/engines/ultima/ultima0/ultima0.h
@@ -37,7 +37,7 @@ namespace Ultima0 {
 class Ultima0Engine : public Engine, public Events {
 private:
 	Common::RandomSource _randomSource;
-	const UltimaGameDescription *_gameDescription;
+	//const UltimaGameDescription *_gameDescription;
 
 	void syncSavegame(Common::Serializer &s);
 


Commit: a351fa9ab09454bfdd6421b9b66e314a9f4eb067
    https://github.com/scummvm/scummvm/commit/a351fa9ab09454bfdd6421b9b66e314a9f4eb067
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2026-01-04T11:37:20+01:00

Commit Message:
ULTIMA: ULTIMA0: Add missing come in sting constant list

Changed paths:
    engines/ultima/ultima0/views/acknowledgements.cpp


diff --git a/engines/ultima/ultima0/views/acknowledgements.cpp b/engines/ultima/ultima0/views/acknowledgements.cpp
index d42f9750524..79d9f787e48 100644
--- a/engines/ultima/ultima0/views/acknowledgements.cpp
+++ b/engines/ultima/ultima0/views/acknowledgements.cpp
@@ -49,7 +49,7 @@ static const char *LINES[] = {
 	"James Ashley",
 	"Chris Harjo",
 	"and everyone else out there",
-	"who helped me out"
+	"who helped me out",
 	"",
 	"",
 	"",


Commit: 8c5e4f08662f1f4bfea36b4014eb87867976cb9d
    https://github.com/scummvm/scummvm/commit/8c5e4f08662f1f4bfea36b4014eb87867976cb9d
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2026-01-04T11:37:57+01:00

Commit Message:
ULTIMA: ULTIMA0: Comment out unused variable

Changed paths:
    engines/ultima/ultima0/views/town.cpp


diff --git a/engines/ultima/ultima0/views/town.cpp b/engines/ultima/ultima0/views/town.cpp
index eca1756538a..b3800597226 100644
--- a/engines/ultima/ultima0/views/town.cpp
+++ b/engines/ultima/ultima0/views/town.cpp
@@ -28,7 +28,7 @@ namespace Views {
 
 static const char *WELCOME = "Welcome to the Adventure Shop";
 static const char *THANK_YOU = "Thank you m'lord";
-static const char *DONT_HAVE_THAT = "I'm Sorry We Don't have that.";
+//static const char *DONT_HAVE_THAT = "I'm Sorry We Don't have that.";
 static const char *NOT_ENOUGH = "M'Lord thou can not afford that item.";
 static const char *MAGES_CANT_USE = "I'm sorry, Mages can't use that.";
 static const char *BYE = "Bye";


Commit: c84589ba923657b98d2ae4c7382db979d485d4f0
    https://github.com/scummvm/scummvm/commit/c84589ba923657b98d2ae4c7382db979d485d4f0
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2026-01-04T11:39:13+01:00

Commit Message:
ULTIMA: ULTIMA0: Fix warning

Changed paths:
    engines/ultima/ultima0/views/castle.cpp


diff --git a/engines/ultima/ultima0/views/castle.cpp b/engines/ultima/ultima0/views/castle.cpp
index 22e1baa3ee3..3c5728825a4 100644
--- a/engines/ultima/ultima0/views/castle.cpp
+++ b/engines/ultima/ultima0/views/castle.cpp
@@ -111,7 +111,7 @@ void Castle::taskCompleted() {
 			"main objective of the game.\n\n"
 			"Now, maybe thou art foolhardy enough to\n"
 			"try difficulty level ");
-		s.writeString(Common::String::format("%s.", player._skill + 1));
+		s.writeString(Common::String::format("%d.", player._skill + 1));
 	} else {
 		nextTask();