[Scummvm-git-logs] scummvm master -> f80cd803c17fac840979ee2213fd64e6fabaa859

sev- noreply at scummvm.org
Tue Jan 20 00:42:51 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
f80cd803c1 SHERLOCK: More normalization for keymapper actions


Commit: f80cd803c17fac840979ee2213fd64e6fabaa859
    https://github.com/scummvm/scummvm/commit/f80cd803c17fac840979ee2213fd64e6fabaa859
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2026-01-20T01:42:44+01:00

Commit Message:
SHERLOCK: More normalization for keymapper actions

This engine keymappings are very much inconsistent with the rest of
the engines

Changed paths:
    engines/sherlock/metaengine.cpp


diff --git a/engines/sherlock/metaengine.cpp b/engines/sherlock/metaengine.cpp
index 3d54b92a1b8..6ec6746770c 100644
--- a/engines/sherlock/metaengine.cpp
+++ b/engines/sherlock/metaengine.cpp
@@ -796,7 +796,7 @@ Common::KeymapArray SherlockMetaEngine::initKeymaps(const char *target) const {
 		act->addDefaultInputMapping("JOY_A");
 		engineKeymap->addAction(act);
 
-		act = new Common::Action(kStandardActionRightClick, _("Open verb menu / Close menu"));
+		act = new Common::Action(kStandardActionRightClick, _("Open action menu / Close menu"));
 		act->setRightClickEvent();
 		act->addDefaultInputMapping("MOUSE_RIGHT");
 		act->addDefaultInputMapping("JOY_B");
@@ -843,7 +843,7 @@ Common::KeymapArray SherlockMetaEngine::initKeymaps(const char *target) const {
 		act->addDefaultInputMapping("JOY_DOWN");
 		tattooKeymap->addAction(act);
 
-		act = new Action("OPTIONS", _("Open options"));
+		act = new Action("OPTIONS", _("Open options menu"));
 		act->setCustomEngineActionEvent(kActionTattooOptions);
 		act->addDefaultInputMapping("F4");
 		act->addDefaultInputMapping("JOY_LEFT");
@@ -869,7 +869,7 @@ Common::KeymapArray SherlockMetaEngine::initKeymaps(const char *target) const {
 		// Prolog keymap
 		//
 
-		act = new Action("SKIPPROLOG", _("Skip prolog"));
+		act = new Action("SKIPPROLOG", _("Skip intro"));
 		act->setCustomEngineActionEvent(kActionTattooSkipProlog);
 		act->addDefaultInputMapping("ESCAPE");
 		act->addDefaultInputMapping("JOY_Y");
@@ -899,7 +899,7 @@ Common::KeymapArray SherlockMetaEngine::initKeymaps(const char *target) const {
 		tattooJournalKeymap->addAction(act);
 
 		// I18N: (Game name: The Lost Files of Sherlock Holmes: The Case of the Rose Tattoo) The game has a journal, this action is used to go forward 1 page in the journal
-		act = new Action("PAGEFORWARD1", _("Go forward 1 page"));
+		act = new Action("PAGEFORWARD1", _("Next page"));
 		act->setCustomEngineActionEvent(kActionTattooJournalForward1);
 		act->addDefaultInputMapping("PAGEDOWN");
 		act->addDefaultInputMapping("KP3");
@@ -914,21 +914,21 @@ Common::KeymapArray SherlockMetaEngine::initKeymaps(const char *target) const {
 		tattooJournalKeymap->addAction(act);
 
 		// I18N: (Game name: The Lost Files of Sherlock Holmes: The Case of the Rose Tattoo) The game has a journal, this action is used to go back 1 page in the journal
-		act = new Action("PAGEBACK1", _("Go back 1 page"));
+		act = new Action("PAGEBACK1", _("Previous page"));
 		act->setCustomEngineActionEvent(kActionTattooJournalBack1);
 		act->addDefaultInputMapping("PAGEUP");
 		act->addDefaultInputMapping("KP9");
 		act->addDefaultInputMapping("JOY_UP");
 		tattooJournalKeymap->addAction(act);
 
-		act = new Action("GOSTART", _("Go to start of journal"));
+		act = new Action("GOSTART", _("First page"));
 		act->setCustomEngineActionEvent(kActionTattooJournalStart);
 		act->addDefaultInputMapping("HOME");
 		act->addDefaultInputMapping("KP7");
 		act->addDefaultInputMapping("JOY_LEFT_TRIGGER");
 		tattooJournalKeymap->addAction(act);
 
-		act = new Action("GOEND", _("Go to end of journal"));
+		act = new Action("GOEND", _("Last page"));
 		act->setCustomEngineActionEvent(kActionTattooJournalEnd);
 		act->addDefaultInputMapping("END");
 		act->addDefaultInputMapping("KP1");
@@ -1038,14 +1038,14 @@ Common::KeymapArray SherlockMetaEngine::initKeymaps(const char *target) const {
 		tattooScrollingKeymap->addAction(act);
 
 		// I18N: (Game name: The Lost Files of Sherlock Holmes: The Case of the Rose Tattoo) The game has multiple widgets for various purposes (eg. inventory, save files, etc.), this action is used to scroll up by a page in the widget
-		act = new Action("SCROLLPGUP", _("Scroll page up"));
+		act = new Action("SCROLLPGUP", _("Previous page"));
 		act->setCustomEngineActionEvent(kActionTattooWidgetScrollPageUp);
 		act->addDefaultInputMapping("PAGEUP");
 		act->addDefaultInputMapping("KP9");
 		tattooScrollingKeymap->addAction(act);
 
 		// I18N: (Game name: The Lost Files of Sherlock Holmes: The Case of the Rose Tattoo) The game has multiple widgets for various purposes (eg. inventory, save files, etc.), this action is used to scroll down by a page in the widget
-		act = new Action("SCROLLPGDOWN", _("Scroll page down"));
+		act = new Action("SCROLLPGDOWN", _("Next page"));
 		act->setCustomEngineActionEvent(kActionTattooWidgetScrollPageDown);
 		act->addDefaultInputMapping("PAGEDOWN");
 		act->addDefaultInputMapping("KP3");




More information about the Scummvm-git-logs mailing list