[Scummvm-git-logs] scummvm master -> f43ea129cf8313d6b0fb5d20d46164b9212ad384

[bluegr]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
f43ea129cf SCI32: Remove GK2 fan subtitle suggestion


Commit: f43ea129cf8313d6b0fb5d20d46164b9212ad384
    https://github.com/scummvm/scummvm/commit/f43ea129cf8313d6b0fb5d20d46164b9212ad384
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2026-01-28T09:38:07+02:00

Commit Message:
SCI32: Remove GK2 fan subtitle suggestion

Changed paths:
    engines/sci/sci.cpp
    engines/sci/sci.h


diff --git a/engines/sci/sci.cpp b/engines/sci/sci.cpp
index 2853a85d228..b4d28b797c5 100644
--- a/engines/sci/sci.cpp
+++ b/engines/sci/sci.cpp
@@ -458,10 +458,6 @@ Common::Error SciEngine::run() {
 		warning("Fan made script patch detected");
 	}
 
-	if (getGameId() == GID_GK2 && ConfMan.getBool("subtitles") && !_resMan->testResource(ResourceId(kResourceTypeSync, 10))) {
-		suggestDownloadGK2SubTitlesPatch();
-	}
-
 	runGame();
 
 	ConfMan.flushToDisk();
@@ -523,36 +519,6 @@ bool SciEngine::gameHasFanMadePatch() {
 	return false;
 }
 
-void SciEngine::suggestDownloadGK2SubTitlesPatch() {
-	Common::U32String altButton;
-	Common::U32String downloadMessage;
-
-	if (_system->hasFeature(OSystem::kFeatureOpenUrl)) {
-		altButton = _("Download patch");
-		downloadMessage = _("(or click 'Download patch' button. But note - it only downloads, you will have to continue from there)\n");
-	}
-	else {
-		altButton = "";
-		downloadMessage = "";
-	}
-
-	int result = showScummVMDialog(_("GK2 has fan made subtitles, available thanks to the good people at SierraHelp.\n\n"
-		"Installation:\n"
-		"- download http://www.sierrahelp.com/Files/Patches/GabrielKnight/GK2Subtitles.zip\n" +
-		downloadMessage +
-		"- extract zip file\n"
-		"- no need to run the .exe file\n"
-		"- extract the .exe file with a file archiver, like 7-zip\n"
-		"- create a PATCHES subdirectory inside your GK2 directory\n"
-		"- copy the content of GK2Subtitles\\SUBPATCH to the PATCHES subdirectory\n"
-		"- replace files with similar names\n"
-		"- restart the game\n"), altButton, false);
-	if (result) {
-		char url[] = "http://www.sierrahelp.com/Files/Patches/GabrielKnight/GK2Subtitles.zip";
-		_system->openUrl(url);
-	}
-}
-
 bool SciEngine::initGame() {
 	// Script 0 needs to be allocated here before anything else!
 	int script0Segment = _gamestate->_segMan->getScriptSegment(0, SCRIPT_GET_LOCK);
diff --git a/engines/sci/sci.h b/engines/sci/sci.h
index b605e539686..d936170077c 100644
--- a/engines/sci/sci.h
+++ b/engines/sci/sci.h
@@ -296,10 +296,6 @@ public:
 	// Initializes ports and paint16 for non-sci32 games, also sets default palette
 	void initGraphics();
 
-	// Suggest to download the GK2 subtitles patch
-	// in the future, we might refactor it to something more generic, if needed
-	void suggestDownloadGK2SubTitlesPatch();
-
 public:
 	GfxAnimate *_gfxAnimate; // Animate for 16-bit gfx
 	GfxCache *_gfxCache;