[Scummvm-git-logs] scummvm master -> 549f1ec0cc82b789b6c0ba31ab5322fe6b69979b

[criezy]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
549f1ec0cc DEVTOOLS: Fix Release configuration in Xcode projects


Commit: 549f1ec0cc82b789b6c0ba31ab5322fe6b69979b
    https://github.com/scummvm/scummvm/commit/549f1ec0cc82b789b6c0ba31ab5322fe6b69979b
Author: Thierry Crozat (criezy at scummvm.org)
Date: 2026-07-11T01:15:05+01:00

Commit Message:
DEVTOOLS: Fix Release configuration in Xcode projects

This partially revert commit b054ef0.
One loop on the build configurations incremented the vector iterator
inside the loop. Changing the loop to use C++11 range loop caused it
to increment the vector item instead of the iterator.
Change to use C++11 range loop introduced a bug for one of the loop
that incremente

Changed paths:
    devtools/create_project/xcode.cpp


diff --git a/devtools/create_project/xcode.cpp b/devtools/create_project/xcode.cpp
index 20779d3ab8d..fff6bdfc278 100644
--- a/devtools/create_project/xcode.cpp
+++ b/devtools/create_project/xcode.cpp
@@ -1620,15 +1620,15 @@ void XcodeProvider::setupBuildConfiguration(const BuildSetup &setup) {
 	}
 
 	// Warning: This assumes we have all configurations with a Debug & Release pair
-	for (const auto *config : _buildConfiguration._objects) {
+	for (std::vector<Object *>::iterator config = _buildConfiguration._objects.begin(); config != _buildConfiguration._objects.end(); config++) {
 
-		Object *configList = new Object(this, "XCConfigurationList_" + config->_name, config->_name, "XCConfigurationList", "", "Build configuration list for " + config->_refType + " \"" + config->_name + "\"");
+		Object *configList = new Object(this, "XCConfigurationList_" + (*config)->_name, (*config)->_name, "XCConfigurationList", "", "Build configuration list for " + (*config)->_refType + " \"" + (*config)->_name + "\"");
 
 		Property buildConfigs;
 		buildConfigs._flags = kSettingsAsList;
 
-		buildConfigs._settings[getHash(config->_id)] = Setting("", "Debug", kSettingsNoValue, 0, 0);
-		buildConfigs._settings[getHash((++config)->_id)] = Setting("", "Release", kSettingsNoValue, 0, 1);
+		buildConfigs._settings[getHash((*config)->_id)] = Setting("", "Debug", kSettingsNoValue, 0, 0);
+		buildConfigs._settings[getHash((*(++config))->_id)] = Setting("", "Release", kSettingsNoValue, 0, 1);
 
 		configList->_properties["buildConfigurations"] = buildConfigs;