[Scummvm-git-logs] scummvm master -> bd1057ff8b1fab3fd13291e4a8b0fede823695a0

[mgerhardy]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
bd1057ff8b MACS2: leaving a TODO comment for further investigation


Commit: bd1057ff8b1fab3fd13291e4a8b0fede823695a0
    https://github.com/scummvm/scummvm/commit/bd1057ff8b1fab3fd13291e4a8b0fede823695a0
Author: Martin Gerhardy (martin.gerhardy at gmail.com)
Date: 2026-07-16T09:44:34+02:00

Commit Message:
MACS2: leaving a TODO comment for further investigation

Changed paths:
    engines/macs2/view1.cpp


diff --git a/engines/macs2/view1.cpp b/engines/macs2/view1.cpp
index 1e1fd25fd44..787bc03647c 100644
--- a/engines/macs2/view1.cpp
+++ b/engines/macs2/view1.cpp
@@ -3454,6 +3454,10 @@ bool Character::calculatePath(Common::Point target) {
 			// due to calculatePath being invoked with swapped source/dest params.
 			// This means the gate check is "can node see CHARACTER" and the flood-fill
 			// checks "any node reachable from DEST" AND "any node visible from CHARACTER".
+			// TODO: validate this with a playthought:
+			//   PVS-Studio V764: Possible incorrect order of arguments passed to
+			//   'canNodeConnectSourceToTarget' function: 'target' and 'charPos'.
+			// I didn't had any issues in previous runs
 			if (canNodeConnectSourceToTarget(i, target, charPos, reachable, nodeCount)) {
 				// Recompute cost (binary does this twice)
 				costToDest = g_engine->euclideanDistance(nodePos, target);