[Scummvm-git-logs] scummvm master -> b911a524e3180969aac31f22cfb24f6c750d6793

sev- noreply at scummvm.org
Thu Jul 23 13:58:54 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
b911a524e3 DIRECTOR: Preserve the member type when duplicating buttons


Commit: b911a524e3180969aac31f22cfb24f6c750d6793
    https://github.com/scummvm/scummvm/commit/b911a524e3180969aac31f22cfb24f6c750d6793
Author: Gianluca Boiano (morf3089 at gmail.com)
Date: 2026-07-23T15:58:50+02:00

Commit Message:
DIRECTOR: Preserve the member type when duplicating buttons

The copy constructor forced kCastText, so a duplicated button came back
as a plain text member (and its on-disk type no longer matched).

Fixes duplicated buttons reloading as text members

Changed paths:
    engines/director/castmember/text.cpp


diff --git a/engines/director/castmember/text.cpp b/engines/director/castmember/text.cpp
index 443bf1c88ca..8efcab40116 100644
--- a/engines/director/castmember/text.cpp
+++ b/engines/director/castmember/text.cpp
@@ -160,7 +160,7 @@ TextCastMember::TextCastMember(Cast *cast, uint16 castId, Common::SeekableReadSt
 
 TextCastMember::TextCastMember(Cast *cast, uint16 castId, TextCastMember &source)
 	: CastMember(cast, castId) {
-	_type = kCastText;
+	_type = source._type;	// kCastText or kCastButton
 	// force a load so we can copy the cast resource information
 	source.load();
 	_loaded = true;




More information about the Scummvm-git-logs mailing list