[Scummvm-git-logs] scummvm master -> 3909b2add5211fa02dbb331e8ba7929ac038a24c

bluegr noreply at scummvm.org
Tue Jul 28 10:29:27 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
3909b2add5 SCI: Fix RTL text box clipping


Commit: 3909b2add5211fa02dbb331e8ba7929ac038a24c
    https://github.com/scummvm/scummvm/commit/3909b2add5211fa02dbb331e8ba7929ac038a24c
Author: Zvika Haramaty (haramaty.zvika at gmail.com)
Date: 2026-07-28T13:29:22+03:00

Commit Message:
SCI: Fix RTL text box clipping

Avoid applying the RTL left-padding compensation when the first line is
already drawn at offset 0. This prevents Hebrew text from shifting past the
box edge and losing the leftmost pixel column.

This fixes https://github.com/adventurebrew/HebrewAdventure/issues/14

Changed paths:
    engines/sci/graphics/text16.cpp


diff --git a/engines/sci/graphics/text16.cpp b/engines/sci/graphics/text16.cpp
index 9e5647f3d6e..3594c77dfe9 100644
--- a/engines/sci/graphics/text16.cpp
+++ b/engines/sci/graphics/text16.cpp
@@ -647,7 +647,7 @@ void GfxText16::Box(const char *text, uint16 languageSplitter, bool show, const
 		}
 
 
-		if (g_sci->isLanguageRTL())
+		if (g_sci->isLanguageRTL() && offset > 0)
 			// In the game fonts, characters have spacing on the left, and no spacing on the right,
 			// therefore, when we start drawing from the right, they "start from the border"
 			// e.g., in SQ3 Hebrew user's input prompt.




More information about the Scummvm-git-logs mailing list