[Scummvm-git-logs] scummvm master -> ce030b5d91572cc28d88ba6c1357c80c889cc87c

mduggan noreply at scummvm.org
Mon Jun 29 10:41:39 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
ce030b5d91 ACCESS: Fix more small coverity warnings


Commit: ce030b5d91572cc28d88ba6c1357c80c889cc87c
    https://github.com/scummvm/scummvm/commit/ce030b5d91572cc28d88ba6c1357c80c889cc87c
Author: Matthew Duggan (mgithub at guarana.org)
Date: 2026-06-29T20:40:28+10:00

Commit Message:
ACCESS: Fix more small coverity warnings

Changed paths:
    engines/access/noctropolis/noctropolis_game.cpp
    engines/access/noctropolis/noctropolis_resources.cpp


diff --git a/engines/access/noctropolis/noctropolis_game.cpp b/engines/access/noctropolis/noctropolis_game.cpp
index 0d990c901c2..0d8b2380cc7 100644
--- a/engines/access/noctropolis/noctropolis_game.cpp
+++ b/engines/access/noctropolis/noctropolis_game.cpp
@@ -228,7 +228,8 @@ void NoctropolisEngine::doPublisherLogo() {
 		pngFile.open(nightDive);
 
 		Image::PNGDecoder decoder;
-		decoder.loadStream(pngFile);
+		if (!decoder.loadStream(pngFile))
+			error("Failed to load nightdive logo nds.png");
 
 		// Find the best 8-bit palette for this logo as the png is 24-bit and we're
 		// not changing the output surface format for this one logo at the start!
diff --git a/engines/access/noctropolis/noctropolis_resources.cpp b/engines/access/noctropolis/noctropolis_resources.cpp
index c3a1c708af0..0555858d8c2 100644
--- a/engines/access/noctropolis/noctropolis_resources.cpp
+++ b/engines/access/noctropolis/noctropolis_resources.cpp
@@ -2004,7 +2004,7 @@ void NoctropolisResources::load(Common::SeekableReadStream &s) {
 	int i = 0;
 	while (i < ARRAYSIZE(MENU_POLYS)) {
 		_menus.push_back(MENU_POLYS + i);
-		while (MENU_POLYS[i] != Polygon::LISTEND)
+		while (MENU_POLYS[i] != Polygon::LISTEND && i < ARRAYSIZE(MENU_POLYS))
 			i++;
 		i++;
 	}




More information about the Scummvm-git-logs mailing list