[Scummvm-git-logs] scummvm master -> 8edf55ced641be99e15df860f7666e53fc05e9e5

dwatteau noreply at scummvm.org
Mon Mar 9 15:36:21 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
8edf55ced6 MACOS: Fix COREAUDIO_DISABLE_REVERB builds


Commit: 8edf55ced641be99e15df860f7666e53fc05e9e5
    https://github.com/scummvm/scummvm/commit/8edf55ced641be99e15df860f7666e53fc05e9e5
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2026-03-09T16:35:30+01:00

Commit Message:
MACOS: Fix COREAUDIO_DISABLE_REVERB builds

Current compilers don't like the RequireNoErr() calls using a `goto`
nearby, as the `usesReverb` variable gets initialized between them
(only when this define is on, that is).

Changed paths:
    backends/midi/coreaudio.cpp


diff --git a/backends/midi/coreaudio.cpp b/backends/midi/coreaudio.cpp
index 0ca0cd8c16d..eb5ef259419 100644
--- a/backends/midi/coreaudio.cpp
+++ b/backends/midi/coreaudio.cpp
@@ -157,12 +157,13 @@ int MidiDriver_CORE::open() {
 	// Disable reverb mode, as that sucks up a lot of CPU power, which can
 	// be painful on low end machines.
 	// TODO: Make this customizable via a config key?
-	UInt32 usesReverb = 0;
-	AudioUnitSetProperty (_synth, kMusicDeviceProperty_UsesInternalReverb,
-		kAudioUnitScope_Global, 0, &usesReverb, sizeof (usesReverb));
+	{
+		UInt32 usesReverb = 0;
+		AudioUnitSetProperty(_synth, kMusicDeviceProperty_UsesInternalReverb,
+			kAudioUnitScope_Global, 0, &usesReverb, sizeof(usesReverb));
+	}
 #endif
 
-
 	// Finally: Start the graph!
 	RequireNoErr(AUGraphStart(_auGraph));
 




More information about the Scummvm-git-logs mailing list