[Scummvm-git-logs] scummvm master -> 5cea2cce0aa9a531b363191d4b25f470990222a4

whoozle noreply at scummvm.org
Fri Mar 13 10:45:00 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
5cea2cce0a PHOENIXVR: reworked handling of vertical angle range


Commit: 5cea2cce0aa9a531b363191d4b25f470990222a4
    https://github.com/scummvm/scummvm/commit/5cea2cce0aa9a531b363191d4b25f470990222a4
Author: Vladimir Menshakov (vladimir.menshakov at gmail.com)
Date: 2026-03-13T10:43:51Z

Commit Message:
PHOENIXVR: reworked handling of vertical angle range

Move angle correction to AngleY, override resetRange(), set default range of 3/8 * pi

Changed paths:
    engines/phoenixvr/angle.h
    engines/phoenixvr/phoenixvr.h


diff --git a/engines/phoenixvr/angle.h b/engines/phoenixvr/angle.h
index 3bcd005d743..00ba3d77bce 100644
--- a/engines/phoenixvr/angle.h
+++ b/engines/phoenixvr/angle.h
@@ -112,7 +112,17 @@ struct AngleX : Angle {
 };
 
 struct AngleY : Angle {
-	AngleY(float angle) : Angle(angle, -kPi, -Math::epsilon) {}
+	AngleY(float angle) : Angle(angle, -kPi, -Math::epsilon) {
+		resetRange();
+	}
+	void setRange(float min, float max) {
+		static const float baseX = -kPi2;
+		Angle::setRange(baseX + min, baseX + max);
+	}
+	void resetRange() {
+		static constexpr auto defaultRange = kPi * 0.375f;
+		setRange(-defaultRange, defaultRange);
+	}
 	void add(float v) {
 		v += angle();
 		if (v <= _min)
diff --git a/engines/phoenixvr/phoenixvr.h b/engines/phoenixvr/phoenixvr.h
index 493ca786dc7..576e9b836bf 100644
--- a/engines/phoenixvr/phoenixvr.h
+++ b/engines/phoenixvr/phoenixvr.h
@@ -150,8 +150,7 @@ public:
 	void fade(int start, int stop, int speed);
 
 	void setXMax(float max) {
-		static const float baseX = -kPi2;
-		_angleY.setRange(baseX - max, baseX + max);
+		_angleY.setRange(-max, max);
 	}
 
 	// this is set to large values and effectively useless




More information about the Scummvm-git-logs mailing list