[Scummvm-git-logs] scummvm master -> e50f14107b6c2c05d943457b8c3f346fc9075c7a
sluicebox
noreply at scummvm.org
Tue Mar 17 05:17:50 UTC 2026
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .
Summary:
e50f14107b SCI: Handle invalid messages with `warning` instead of `error`
Commit: e50f14107b6c2c05d943457b8c3f346fc9075c7a
https://github.com/scummvm/scummvm/commit/e50f14107b6c2c05d943457b8c3f346fc9075c7a
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2026-03-17T00:06:18-05:00
Commit Message:
SCI: Handle invalid messages with `warning` instead of `error`
The LSL7 Russian "Fargus" translation contains a message resource that
was incorrectly compressed. This was a non-fatal error in SSCI, so now
we use `warning` instead of `error` to allow the game to proceed.
Fixes bug #16597
Thanks to @Omar2002 for reporting
Changed paths:
engines/sci/engine/message.cpp
diff --git a/engines/sci/engine/message.cpp b/engines/sci/engine/message.cpp
index 71ca61bef30..a2b3da76749 100644
--- a/engines/sci/engine/message.cpp
+++ b/engines/sci/engine/message.cpp
@@ -228,7 +228,10 @@ bool MessageState::getRecord(CursorStack &stack, bool recurse, MessageRecord &re
reader = new MessageReaderV4(*res);
break;
default:
- error("Message: unsupported resource version %d", version);
+ // Ignore message resources with invalid versions.
+ // The LSL7 Russian "Fargus" translation contains an incorrectly
+ // compressed message resource that fails this check. Bug #16597
+ warning("Message: unsupported resource version %d", version);
return false;
}
More information about the Scummvm-git-logs
mailing list