[Scummvm-git-logs] scummvm master -> 84825ae722422b7eaede872eb5427e7a3cc32226

[sdelamarre]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
66190d8030 GOB: Don't override dirt rect with fullscreen update
84825ae722 GOB: Remove dubious force blit


Commit: 66190d8030ed4f0b02f58a2cde2d9439bc51780e
    https://github.com/scummvm/scummvm/commit/66190d8030ed4f0b02f58a2cde2d9439bc51780e
Author: Miro Kropacek (miro.kropacek at gmail.com)
Date: 2026-03-24T23:50:01+01:00

Commit Message:
GOB: Don't override dirt rect with fullscreen update

For some reason this code has been present since the creation of this
file. I believe it is a leftover from a debugging session because just a
few lines above the dirty rect is carefully calculated and then
completely ignored.

Fixes the first issue reported in https://bugs.scummvm.org/ticket/14574.

Changed paths:
    engines/gob/goblin.cpp


diff --git a/engines/gob/goblin.cpp b/engines/gob/goblin.cpp
index 730e818f4d3..fa7e5022a30 100644
--- a/engines/gob/goblin.cpp
+++ b/engines/gob/goblin.cpp
@@ -265,11 +265,6 @@ void Goblin::drawObjects() {
 			objDesc->dirtyBottom =
 			    MAX(objDesc->bottom, _vm->_scenery->_toRedrawBottom);
 		}
-
-		objDesc->dirtyLeft = 0;
-		objDesc->dirtyRight = 319;
-		objDesc->dirtyTop = 0;
-		objDesc->dirtyBottom = 199;
 	}
 
 	sortByOrder(_objList);


Commit: 84825ae722422b7eaede872eb5427e7a3cc32226
    https://github.com/scummvm/scummvm/commit/84825ae722422b7eaede872eb5427e7a3cc32226
Author: Miro Kropacek (miro.kropacek at gmail.com)
Date: 2026-03-24T23:50:01+01:00

Commit Message:
GOB: Remove dubious force blit

Commit 51fd528f added this code without further explanation and then
commit 7c14cf2b limited its usage for non-video rendering.

Called very often during intro/credits and/or game play in Geisha,
Gob2, Gob3, Playtoons, Urban and Ween and sporadically (usually
triggered by mouse click) in Bargon Attack, Croustibat, Fascination and
Lost in Time.

Changed paths:
    engines/gob/inter_v1.cpp


diff --git a/engines/gob/inter_v1.cpp b/engines/gob/inter_v1.cpp
index e5911e5dc79..ec3b46270c9 100644
--- a/engines/gob/inter_v1.cpp
+++ b/engines/gob/inter_v1.cpp
@@ -1348,11 +1348,6 @@ void Inter_v1::o1_palLoad(OpFuncParams &params) {
 }
 
 void Inter_v1::o1_keyFunc(OpFuncParams &params) {
-	if (!_vm->_vidPlayer->isPlayingLive()) {
-		_vm->_draw->forceBlit();
-		_vm->_video->retrace();
-	}
-
 	animPalette();
 	_vm->_draw->blitInvalidated();