[Scummvm-git-logs] scummvm master -> 138a266d6ec24a18aa1b67750b99b7ae88f853cb

[sluicebox]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
da6efd519b SCI: Add detection for SQ3 Russian fan translation
138a266d6e SCI: Reduce kAddMenu validation from `error` to `warning`


Commit: da6efd519b4e2adfba0f7f783613dc72a232f289
    https://github.com/scummvm/scummvm/commit/da6efd519b4e2adfba0f7f783613dc72a232f289
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2026-05-03T13:33:10-07:00

Commit Message:
SCI: Add detection for SQ3 Russian fan translation

Changed paths:
    engines/sci/detection_tables.h


diff --git a/engines/sci/detection_tables.h b/engines/sci/detection_tables.h
index 03ac70a34a7..06b0f831105 100644
--- a/engines/sci/detection_tables.h
+++ b/engines/sci/detection_tables.h
@@ -5983,6 +5983,13 @@ static const struct ADGameDescription SciGameDescriptions[] = {
 		AD_LISTEND},
 		Common::ES_ESP, Common::kPlatformDOS, ADGF_NO_FLAGS, GUIO_STD16_PALETTEMODS },
 
+	// Space Quest 3 - Russian fan translation by Igor Malyshko
+	{ "sq3", "", {
+		{"resource.map", 0, "7f1a45f497a8b93dce14147807ce383c", 3726},
+		{"resource.001", 0, "b62b0f98ff876304a5af214c9557f266", 1674902},
+		AD_LISTEND},
+		Common::RU_RUS, Common::kPlatformDOS, ADGF_NO_FLAGS, GUIO_STD16_PALETTEMODS },
+
 #define GUIO_SQ4_CD GUIO6(GAMEOPTION_SQ4_SILVER_CURSORS,	\
 						  GAMEOPTION_PREFER_DIGITAL_SFX,	\
 						  GAMEOPTION_ORIGINAL_SAVELOAD,		\


Commit: 138a266d6ec24a18aa1b67750b99b7ae88f853cb
    https://github.com/scummvm/scummvm/commit/138a266d6ec24a18aa1b67750b99b7ae88f853cb
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2026-05-03T13:33:10-07:00

Commit Message:
SCI: Reduce kAddMenu validation from `error` to `warning`

The SQ3 Russian fan translation has a menu item string with two
consecutive ` characters. This is incorrect, but it didn't cause
a problem in Sierra's interpreter. Reducing our validation to
a warning allows the game to run with expected menu behavior.

Fixes bug #16642

Changed paths:
    engines/sci/graphics/menu.cpp


diff --git a/engines/sci/graphics/menu.cpp b/engines/sci/graphics/menu.cpp
index 0fea1671291..cdabf3bf1d7 100644
--- a/engines/sci/graphics/menu.cpp
+++ b/engines/sci/graphics/menu.cpp
@@ -110,8 +110,11 @@ void GfxMenu::kernelAddEntry(const Common::String &title, Common::String content
 				tagPos = curPos;
 				break;
 			case '`': // Right-aligned
-				if (rightAlignedPos)
-					error("multiple right-aligned markers within one menu-item");
+				if (rightAlignedPos) {
+					// SQ3 Russian translation has two consecutive ` characters.
+					// SSCI tolerated this, so warn instead of error. Bug #16642
+					warning("multiple right-aligned markers within one menu-item");
+				}
 				rightAlignedPos = curPos;
 				break;
 			case '^': // Ctrl-prefix