[Scummvm-git-logs] scummvm-tools master -> 23004e62a1c5afcc59196b4aeaf5ff38c9663851

[sev-]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm-tools' repo located at https://api.github.com/repos/scummvm/scummvm-tools .

Summary:
5629b89b58 PRINCE: Fix syntax error in po-parse.pl
23004e62a1 PRINCE: gen-translations.sh expects an input filename now


Commit: 5629b89b58d2864b20e713ac291d9422f48a2249
    https://github.com/scummvm/scummvm-tools/commit/5629b89b58d2864b20e713ac291d9422f48a2249
Author: Dries Harnie (dries at harnie.be)
Date: 2026-05-18T17:52:25+02:00

Commit Message:
PRINCE: Fix syntax error in po-parse.pl

The `keys $var` form was removed in Perl 5.24. Replaced with the correct
`keys %{$var}` form.

Changed paths:
    engines/prince/po-parse.pl


diff --git a/engines/prince/po-parse.pl b/engines/prince/po-parse.pl
index bc9fc2d8..f7307633 100644
--- a/engines/prince/po-parse.pl
+++ b/engines/prince/po-parse.pl
@@ -136,7 +136,7 @@ sub process_inv($) {
 
 	print OUT "invtxt.dat\nitemNr. name - exam text\n";
 
-	for my $n (sort {$a<=>$b} keys $data1{'invtxt.txt'}) {
+	for my $n (sort {$a<=>$b} keys %{$data1{'invtxt.txt'}}) {
 		print OUT "$n. $data1{'invtxt.txt'}{$n}\n";
 	}
 
@@ -150,7 +150,7 @@ sub process_varia($) {
 
 	print OUT "variatxt.dat\nstringId. string\n";
 
-	for my $n (sort {$a<=>$b} keys $data1{'variatxt.txt'}) {
+	for my $n (sort {$a<=>$b} keys %{$data1{'variatxt.txt'}}) {
 		print OUT "$n. $data1{'variatxt.txt'}{$n}\n";
 	}
 
@@ -166,7 +166,7 @@ sub process_mob($) {
 
 	my $pn = 0;
 
-	for my $n (sort {$a<=>$b} keys $data1{'mob.lst'}) {
+	for my $n (sort {$a<=>$b} keys %{$data1{'mob.lst'}}) {
 		my $p1 = int($n / 1000);
 
 		if ($p1 != $pn) {
@@ -197,7 +197,7 @@ sub process_talk($) {
 	for my $f (sort grep /^dialog/, keys %data1) {
 		$f =~ /dialog(\d+)/;
 		my $dialog = $1;
-		my $hasDialog = !!grep { $_ > 100 } keys $data1{$f};
+		my $hasDialog = !!grep { $_ > 100 } keys %{$data1{$f}};
 
 		if ($hasDialog) {
 			print OUT "\@DIALOGBOX_LINES:\n";
@@ -208,7 +208,7 @@ sub process_talk($) {
 		my $seenDialogBox = 0;
 		my $prevBox = -1;
 
-		for my $n (sort {$a<=>$b} keys $data1{$f}) {
+		for my $n (sort {$a<=>$b} keys %{$data1{$f}}) {
 			my $s = $data1{$f}{$n};
 			if ($n < 100) {
 				while ($s =~ /^P#/) {


Commit: 23004e62a1c5afcc59196b4aeaf5ff38c9663851
    https://github.com/scummvm/scummvm-tools/commit/23004e62a1c5afcc59196b4aeaf5ff38c9663851
Author: Dries Harnie (dries at harnie.be)
Date: 2026-05-18T17:52:25+02:00

Commit Message:
PRINCE: gen-translations.sh expects an input filename now

This script used to reference a submodule in the ScummVM source tree
with the translation sources.
That submodule was removed, so the script now expects an argument and
prints a hint if the directory does not exist:

```
% ./engines/prince/gen-translations.sh
Usage: ./engines/prince/gen-translations.sh <path-to-scummvm-game-translations>
Download or clone from https://github.com/scummvm/game-translations/tree/prince-and-the-coward
```

Changed paths:
    engines/prince/gen-translations.sh


diff --git a/engines/prince/gen-translations.sh b/engines/prince/gen-translations.sh
index e50cb5aa..c668ef2b 100755
--- a/engines/prince/gen-translations.sh
+++ b/engines/prince/gen-translations.sh
@@ -1,6 +1,15 @@
 #! /bin/bash
 
-cp -v ../../../scummvm/devtools/create_prince/en.po .
+set -e
+
+translations_dir="$1"
+if [ -z "$translations_dir" ] || [ ! -d "$translations_dir" ]; then
+  echo "Usage: $0 <path-to-scummvm-game-translations>" >&2
+  echo "Download or clone from https://github.com/scummvm/game-translations/tree/prince-and-the-coward" >&2
+  exit 1
+fi
+
+cp -v "$translations_dir"/en.po .
 perl po-parse.pl en en.po
 ../../scummvm-tools-cli --tool pack_prince .
 cp -v prince_translation.dat ../../../scummvm/dists/engine-data/