[Scummvm-git-logs] scummvm master -> bcbac0371531984e8f0d4a734b671fee77a2eea9

mduggan noreply at scummvm.org
Sat May 23 06:15:28 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
bcbac03715 ACCESS: Add some missing breaks on switches


Commit: bcbac0371531984e8f0d4a734b671fee77a2eea9
    https://github.com/scummvm/scummvm/commit/bcbac0371531984e8f0d4a734b671fee77a2eea9
Author: Matthew Duggan (mgithub at guarana.org)
Date: 2026-05-23T16:15:08+10:00

Commit Message:
ACCESS: Add some missing breaks on switches

Changed paths:
    engines/access/noctropolis/noctropolis_player.cpp
    engines/access/noctropolis/noctropolis_scripts.cpp


diff --git a/engines/access/noctropolis/noctropolis_player.cpp b/engines/access/noctropolis/noctropolis_player.cpp
index a511b61ef72..d21f0176e73 100644
--- a/engines/access/noctropolis/noctropolis_player.cpp
+++ b/engines/access/noctropolis/noctropolis_player.cpp
@@ -222,15 +222,15 @@ void NoctropolisPlayer::walk() {
 void NoctropolisPlayer::setDirFromScript(byte newDir) {
 	// The opposite of _animNumForDir above.
 	switch (newDir) {
-	case 0: _playerDirection = UP;
-	case 1: _playerDirection = UPRIGHT;
-	case 2: _playerDirection = RIGHT;
-	case 3: _playerDirection = DOWNRIGHT;
-	case 4: _playerDirection = DOWN;
-	case 5: _playerDirection = DOWNLEFT;
-	case 6: _playerDirection = LEFT;
-	case 7: _playerDirection = UPLEFT;
-	default: _playerDirection = NONE;
+	case 0: _playerDirection = UP;			break;
+	case 1: _playerDirection = UPRIGHT;		break;
+	case 2: _playerDirection = RIGHT; 		break;
+	case 3: _playerDirection = DOWNRIGHT;	break;
+	case 4: _playerDirection = DOWN;		break;
+	case 5: _playerDirection = DOWNLEFT;	break;
+	case 6: _playerDirection = LEFT;		break;
+	case 7: _playerDirection = UPLEFT;		break;
+	default: _playerDirection = NONE;		break;
 	}
 }
 
diff --git a/engines/access/noctropolis/noctropolis_scripts.cpp b/engines/access/noctropolis/noctropolis_scripts.cpp
index 0b49f02ea04..5d57ee67b0b 100644
--- a/engines/access/noctropolis/noctropolis_scripts.cpp
+++ b/engines/access/noctropolis/noctropolis_scripts.cpp
@@ -132,6 +132,7 @@ bool NoctropolisScripts::executeSpecial(int commandIndex, int param1, int param2
 		_vm->_player->load();
 		_vm->_screen->setManPalette();
 		_vm->_screen->setPalette();
+		break;
 	case 7:
 		vm->_midi->loadMusic(98, param1);
 		break;




More information about the Scummvm-git-logs mailing list