[Scummvm-git-logs] scummvm master -> 6b99a75b1c7f2cf9dfc7d8363322ac66dd0b6865

mgerhardy noreply at scummvm.org
Sun May 24 14:55:30 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
6b99a75b1c TWINE: fixed holomap entity rendering


Commit: 6b99a75b1c7f2cf9dfc7d8363322ac66dd0b6865
    https://github.com/scummvm/scummvm/commit/6b99a75b1c7f2cf9dfc7d8363322ac66dd0b6865
Author: Martin Gerhardy (martin.gerhardy at gmail.com)
Date: 2026-05-24T16:08:44+02:00

Commit Message:
TWINE: fixed holomap entity rendering

the coordinates are negative from -1000 to 1000 on the holomap because it's a different projection - so we need to allow negative coordinates here, too

Changed paths:
    engines/twine/holomap_v1.cpp
    engines/twine/renderer/redraw.h


diff --git a/engines/twine/holomap_v1.cpp b/engines/twine/holomap_v1.cpp
index 5fb0126bed6..5db2557060c 100644
--- a/engines/twine/holomap_v1.cpp
+++ b/engines/twine/holomap_v1.cpp
@@ -301,9 +301,8 @@ void HolomapV1::drawHoloObj(const IVec3 &angle, int32 alpha, int32 beta, int16 s
 	const IVec3 &m = _engine->_renderer->worldRotatePoint(IVec3(0, 0, 1000 + size));
 	_engine->_renderer->setFollowCamera(0, 0, 0, angle.x, angle.y, angle.z, distance(zDistanceTrajectory));
 	_engine->_interface->unsetClip();
-	const IVec3 &m1 = _engine->_renderer->worldRotatePoint(m);
 	Common::Rect dirtyRect;
-	_engine->_renderer->renderIsoModel(m1, alpha, beta, LBAAngles::ANGLE_0, _engine->_resources->_holomapPointModelPtr, dirtyRect);
+	_engine->_renderer->renderIsoModel(m, alpha, beta, LBAAngles::ANGLE_0, _engine->_resources->_holomapPointModelPtr, dirtyRect);
 	_engine->copyBlockPhys(dirtyRect);
 }
 
diff --git a/engines/twine/renderer/redraw.h b/engines/twine/renderer/redraw.h
index b2089df25ec..80a893f5c9c 100644
--- a/engines/twine/renderer/redraw.h
+++ b/engines/twine/renderer/redraw.h
@@ -71,9 +71,9 @@ struct DrawListStruct {
 	// not masking the value in numObj, but store the type in type
 	uint16 numObj = 0;
 
-	uint16 xw = 0;
-	uint16 yw = 0;
-	uint16 zw = 0;
+	int16 xw = 0;
+	int16 yw = 0;
+	int16 zw = 0;
 	uint16 num = 0;
 
 	inline bool operator==(const DrawListStruct& other) const {




More information about the Scummvm-git-logs mailing list