[Scummvm-git-logs] scummvm master -> 475491765e78f87efe26a38fb122dfad9b970a54

dreammaster noreply at scummvm.org
Mon May 25 11:31:54 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
475491765e MADS: DRAGONSPHERE: Fix off-by-one pathfinder line check in buffer_legal


Commit: 475491765e78f87efe26a38fb122dfad9b970a54
    https://github.com/scummvm/scummvm/commit/475491765e78f87efe26a38fb122dfad9b970a54
Author: Paul Gilbert (dreammaster at scummvm.org)
Date: 2026-05-25T21:31:34+10:00

Commit Message:
MADS: DRAGONSPHERE: Fix off-by-one pathfinder line check in buffer_legal

Changed paths:
    engines/mads/madsv2/core/buffer.cpp
    engines/mads/madsv2/dragonsphere/rooms/room105.cpp


diff --git a/engines/mads/madsv2/core/buffer.cpp b/engines/mads/madsv2/core/buffer.cpp
index 1794fd4ac6f..c88bae5aea0 100644
--- a/engines/mads/madsv2/core/buffer.cpp
+++ b/engines/mads/madsv2/core/buffer.cpp
@@ -423,7 +423,7 @@ int buffer_legal(const Buffer &walk, int orig_wrap,
 	for (int col = x_count; col > 0; col--) {
 		dAccum += y_count;
 
-		bool blocked = ((*ptr >> bit_pos) & 1) != 0;
+		bool blocked = ((*ptr >> (bit_pos - 1)) & 1) != 0;
 
 		if (blocked) {
 			if (!currently_illegal) {
@@ -437,7 +437,7 @@ int buffer_legal(const Buffer &walk, int orig_wrap,
 
 		while (dAccum >= x_count) {
 			dAccum -= x_count;
-			blocked = ((*ptr >> bit_pos) & 1) != 0;
+			blocked = ((*ptr >> (bit_pos - 1)) & 1) != 0;
 			if (blocked) {
 				if (!currently_illegal) {
 					currently_illegal = true;
diff --git a/engines/mads/madsv2/dragonsphere/rooms/room105.cpp b/engines/mads/madsv2/dragonsphere/rooms/room105.cpp
index aef37c3279b..ff5280a02dd 100644
--- a/engines/mads/madsv2/dragonsphere/rooms/room105.cpp
+++ b/engines/mads/madsv2/dragonsphere/rooms/room105.cpp
@@ -93,7 +93,7 @@ static Scratch scratch;
 #define WALK_TO_BONE_X       255
 #define WALK_TO_BONE_Y       145
 
-#define WALK_TO_GOBLET_X     65
+#define WALK_TO_GOBLET_X     63
 #define WALK_TO_GOBLET_Y     142
 
 /* cursor points */




More information about the Scummvm-git-logs mailing list