[Scummvm-git-logs] scummvm master -> df11b150fccabf0b8da0d6107888840205460d94

kelmer44 noreply at scummvm.org
Tue May 26 13:42:34 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
df11b150fc PELROCK: remove redundant attribute & fixes nullable pointers in sound module. PVS-Studio V575, V769, V703


Commit: df11b150fccabf0b8da0d6107888840205460d94
    https://github.com/scummvm/scummvm/commit/df11b150fccabf0b8da0d6107888840205460d94
Author: kelmer (kelmer at gmail.com)
Date: 2026-05-26T15:42:24+02:00

Commit Message:
PELROCK: remove redundant attribute & fixes nullable pointers in sound module. PVS-Studio V575, V769, V703

Changed paths:
    engines/pelrock/sound.cpp
    engines/pelrock/video.h


diff --git a/engines/pelrock/sound.cpp b/engines/pelrock/sound.cpp
index 4eda6b9c65e..2ea43433f2a 100644
--- a/engines/pelrock/sound.cpp
+++ b/engines/pelrock/sound.cpp
@@ -202,6 +202,8 @@ int SoundManager::playSound(SonidoFile sound, int channel, int loopCount) {
 
 		uint32 pcmSize = sound.size - headerSize;
 		byte *pcmData = (byte *)malloc(pcmSize);
+		assert(pcmData);
+		assert(data);
 		memcpy(pcmData, data + headerSize, pcmSize);
 		free(data);
 
diff --git a/engines/pelrock/video.h b/engines/pelrock/video.h
index 826fadab3f3..e3ed6b7bc9b 100644
--- a/engines/pelrock/video.h
+++ b/engines/pelrock/video.h
@@ -46,7 +46,6 @@ struct AudioEffect : Effect {
 };
 
 struct Subtitle : Effect {
-	uint16 startFrame;
 	uint16 endFrame;
 	uint16 x;
 	uint16 y;




More information about the Scummvm-git-logs mailing list