[Scummvm-git-logs] scummvm master -> 6fe92f35c6a36494534f38d9a14952fafbebc7d0

[Helco]

This automated email contains information about 4 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
e1dc022a46 ALCACHOFA: Fix playVoice console command. PVS-Studio V547
9b9b508f80 ALCACHOFA: Fix analyzer warning related to exceptions. PVS-Studio V1023
2c31c44718 ALCACHOFA: Ignore analyzer warning in SlideButton. PVS-Studio V656
6fe92f35c6 ALCACHOFA: Ignore analyzer warning in ButtonV1. PVS-Studio V522


Commit: e1dc022a46adf365a91eebdbc1eb108b135f04e9
    https://github.com/scummvm/scummvm/commit/e1dc022a46adf365a91eebdbc1eb108b135f04e9
Author: Helco (hermann.noll at hotmail.com)
Date: 2026-05-28T11:22:26+02:00

Commit Message:
ALCACHOFA: Fix playVoice console command. PVS-Studio V547

Changed paths:
    engines/alcachofa/console.cpp


diff --git a/engines/alcachofa/console.cpp b/engines/alcachofa/console.cpp
index 6dc40a3e592..f02de17f62c 100644
--- a/engines/alcachofa/console.cpp
+++ b/engines/alcachofa/console.cpp
@@ -344,7 +344,7 @@ bool Console::cmdPlaySound(int argc, const char **args) {
 		return true;
 	}
 
-	if (tolower(args[0][5]) == 'V')
+	if (tolower(args[0][4]) == 'v')
 		g_engine->sounds().playVoice(args[1]);
 	else
 		g_engine->sounds().playSFX(args[1]);


Commit: 9b9b508f80ad9defe1ac62304b60c31a4c53bc46
    https://github.com/scummvm/scummvm/commit/9b9b508f80ad9defe1ac62304b60c31a4c53bc46
Author: Helco (hermann.noll at hotmail.com)
Date: 2026-05-28T11:22:26+02:00

Commit Message:
ALCACHOFA: Fix analyzer warning related to exceptions. PVS-Studio V1023

Changed paths:
    engines/alcachofa/rooms.cpp


diff --git a/engines/alcachofa/rooms.cpp b/engines/alcachofa/rooms.cpp
index 33bdd3392f7..f7ee4356e46 100644
--- a/engines/alcachofa/rooms.cpp
+++ b/engines/alcachofa/rooms.cpp
@@ -1081,7 +1081,7 @@ public:
 				lastSep = 0;
 			auto fileName = String::format("%s.%s", fullPath.c_str() + lastSep, extension.c_str());
 			_members.emplace_back(
-				new EmbeddedArchiveMember(fileName, *this, fileOffset, fileOffset + fileSize));
+				new EmbeddedArchiveMember(fileName, *this, fileOffset, fileOffset + fileSize)); //-V1023
 		}
 
 		if (_file->pos() > endPosition)


Commit: 2c31c44718b2adc13c30adcd8deaa2e888df1a1c
    https://github.com/scummvm/scummvm/commit/2c31c44718b2adc13c30adcd8deaa2e888df1a1c
Author: Helco (hermann.noll at hotmail.com)
Date: 2026-05-28T11:22:26+02:00

Commit Message:
ALCACHOFA: Ignore analyzer warning in SlideButton. PVS-Studio V656

Changed paths:
    engines/alcachofa/ui-objects.cpp


diff --git a/engines/alcachofa/ui-objects.cpp b/engines/alcachofa/ui-objects.cpp
index 67354c72653..04f025ca12f 100644
--- a/engines/alcachofa/ui-objects.cpp
+++ b/engines/alcachofa/ui-objects.cpp
@@ -518,8 +518,8 @@ SlideButton::SlideButton(Room *room, SeekableReadStream &stream)
 SlideButtonV2::SlideButtonV2(Room *room, SeekableReadStream &stream)
 	: SlideButton(room, stream) {
 	_valueId = stream.readSint32LE();
-	_minPos = Shape(stream).firstPoint();
-	_maxPos = Shape(stream).firstPoint();
+	_minPos = Shape(stream).firstPoint(); //-V656
+	_maxPos = Shape(stream).firstPoint(); //-V656
 	_graphicIdle = Graphic(stream);
 	_graphicClicked = Graphic(stream);
 }
@@ -527,8 +527,8 @@ SlideButtonV2::SlideButtonV2(Room *room, SeekableReadStream &stream)
 SlideButtonV3::SlideButtonV3(Room *room, SeekableReadStream &stream)
 	: SlideButton(room, stream) {
 	_valueId = stream.readSint32LE();
-	_minPos = Shape(stream).firstPoint();
-	_maxPos = Shape(stream).firstPoint();
+	_minPos = Shape(stream).firstPoint(); //-V656
+	_maxPos = Shape(stream).firstPoint(); //-V656
 	_graphicIdle = Graphic(stream);
 	_graphicHovered = Graphic(stream);
 	_graphicClicked = Graphic(stream);


Commit: 6fe92f35c6a36494534f38d9a14952fafbebc7d0
    https://github.com/scummvm/scummvm/commit/6fe92f35c6a36494534f38d9a14952fafbebc7d0
Author: Helco (hermann.noll at hotmail.com)
Date: 2026-05-28T11:22:26+02:00

Commit Message:
ALCACHOFA: Ignore analyzer warning in ButtonV1. PVS-Studio V522

Changed paths:
    engines/alcachofa/ui-objects.cpp


diff --git a/engines/alcachofa/ui-objects.cpp b/engines/alcachofa/ui-objects.cpp
index 04f025ca12f..3973abece00 100644
--- a/engines/alcachofa/ui-objects.cpp
+++ b/engines/alcachofa/ui-objects.cpp
@@ -169,7 +169,7 @@ void ButtonV1::onClick() {
 MenuV1 &ButtonV1::menu() {
 	auto menuPtr = dynamic_cast<MenuV1 *>(&g_engine->menu());
 	assert(menuPtr != nullptr);
-	return *menuPtr;
+	return *menuPtr; //-V522
 }
 
 const char *MenuButton::typeName() const { return "MenuButton"; }