[Scummvm-git-logs] scummvm master -> d3107d71b5730b1275334f22eec8fff5e52985c7

[bluegr]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
e944597ddd JANITORIAL: GLK: pass strings as references
d3107d71b5 JANITORIAL: GLK: remove unused function argument


Commit: e944597ddd6539fd10da13a5fab0186eebea03a8
    https://github.com/scummvm/scummvm/commit/e944597ddd6539fd10da13a5fab0186eebea03a8
Author: Michael Kuerbis (michael_kuerbis at web.de)
Date: 2026-05-30T15:02:59+03:00

Commit Message:
JANITORIAL: GLK: pass strings as references

Changed paths:
    engines/glk/quetzal.cpp
    engines/glk/scott/c64_checksums.cpp
    engines/glk/scott/load_game.cpp
    engines/glk/scott/load_zx_spectrum.cpp
    engines/glk/scott/load_zx_spectrum.h


diff --git a/engines/glk/quetzal.cpp b/engines/glk/quetzal.cpp
index 71f8e040b5e..1903a510598 100644
--- a/engines/glk/quetzal.cpp
+++ b/engines/glk/quetzal.cpp
@@ -258,7 +258,7 @@ void QuetzalWriter::addCommonChunks(const Common::String &saveName) {
 		else
 			ws.writeByte('\0');
 
-		Common::String md5 = g_vm->getGameMD5();
+		const auto &md5 = g_vm->getGameMD5();
 		ws.write(md5.c_str(), md5.size());
 		ws.writeByte('\0');
 	}
diff --git a/engines/glk/scott/c64_checksums.cpp b/engines/glk/scott/c64_checksums.cpp
index 1596e833fd3..ad2be4e0720 100644
--- a/engines/glk/scott/c64_checksums.cpp
+++ b/engines/glk/scott/c64_checksums.cpp
@@ -402,7 +402,7 @@ int detectC64(uint8_t **sf, size_t *extent) {
 	if (*extent > MAX_LENGTH || *extent < MIN_LENGTH)
 		return 0;
 
-	Common::String md5 = g_vm->getGameMD5();
+	const auto &md5 = g_vm->getGameMD5();
 	int index = _G(_md5Index)[md5];
 	if (g_C64Registry[index]._id == SAVAGE_ISLAND_C64) {
 		return savageIslandMenu(sf, extent, index);
diff --git a/engines/glk/scott/load_game.cpp b/engines/glk/scott/load_game.cpp
index 7bc9696d208..1ecbd44e1aa 100644
--- a/engines/glk/scott/load_game.cpp
+++ b/engines/glk/scott/load_game.cpp
@@ -87,8 +87,8 @@ void loadGameFile(Common::SeekableReadStream *f) {
 
 	_G(_game) = &_G(_fallbackGame);
 
-	Common::String md5 = g_vm->getGameMD5();
-	Common::String filename = g_vm->getFilename();
+	const auto &md5 = g_vm->getGameMD5();
+	const auto &filename = g_vm->getFilename();
 
 	if (filename.hasSuffixIgnoreCase(".tap") || filename.hasSuffixIgnoreCase(".tzx")) {
 		loadZXSpectrumTape(f);
diff --git a/engines/glk/scott/load_zx_spectrum.cpp b/engines/glk/scott/load_zx_spectrum.cpp
index 15ab9f5f794..25dad45e644 100644
--- a/engines/glk/scott/load_zx_spectrum.cpp
+++ b/engines/glk/scott/load_zx_spectrum.cpp
@@ -49,7 +49,7 @@ namespace Scott {
 
 #define TITLE_SCREEN g_globals->_spectrumTitleScreen
 
-static void loadZXSpectrumGame(Common::String md5) {
+static void loadZXSpectrumGame(const Common::String &md5) {
 	int offset;
 	DictionaryType dict_type = getId(&offset);
 	if (dict_type == NOT_A_GAME)
@@ -61,7 +61,7 @@ static void loadZXSpectrumGame(Common::String md5) {
 	}
 }
 
-void loadZXSpectrum(Common::SeekableReadStream *f, Common::String md5) {
+void loadZXSpectrum(Common::SeekableReadStream *f, const Common::String &md5) {
 	TITLE_SCREEN.clear();
 
 	_G(_entireFile) = new uint8_t[_G(_fileLength)];
diff --git a/engines/glk/scott/load_zx_spectrum.h b/engines/glk/scott/load_zx_spectrum.h
index a0cc183e7ac..29f1b52ada5 100644
--- a/engines/glk/scott/load_zx_spectrum.h
+++ b/engines/glk/scott/load_zx_spectrum.h
@@ -40,7 +40,7 @@
 namespace Glk {
 namespace Scott {
 
-void loadZXSpectrum(Common::SeekableReadStream *f, Common::String md5);
+void loadZXSpectrum(Common::SeekableReadStream *f, const Common::String &md5);
 void loadZXSpectrumTape(Common::SeekableReadStream *f);
 void showZXSpectrumTapeTitleScreen();
 


Commit: d3107d71b5730b1275334f22eec8fff5e52985c7
    https://github.com/scummvm/scummvm/commit/d3107d71b5730b1275334f22eec8fff5e52985c7
Author: Michael Kuerbis (michael_kuerbis at web.de)
Date: 2026-05-30T15:02:59+03:00

Commit Message:
JANITORIAL: GLK: remove unused function argument

Changed paths:
    engines/glk/scott/load_game.cpp


diff --git a/engines/glk/scott/load_game.cpp b/engines/glk/scott/load_game.cpp
index 1ecbd44e1aa..fc9b988633a 100644
--- a/engines/glk/scott/load_game.cpp
+++ b/engines/glk/scott/load_game.cpp
@@ -54,7 +54,7 @@
 namespace Glk {
 namespace Scott {
 
-void loadC64(Common::SeekableReadStream* f, Common::String md5) {
+void loadC64(Common::SeekableReadStream* f) {
 	_G(_entireFile) = new uint8_t[_G(_fileLength)];
 	size_t result = f->read(_G(_entireFile), _G(_fileLength));
 	if (result != _G(_fileLength))
@@ -104,7 +104,7 @@ void loadGameFile(Common::SeekableReadStream *f) {
 					loadZXSpectrum(f, md5);
 					break;
 				} else if (!scumm_stricmp(p->_extra, "C64")) {
-					loadC64(f, md5);
+					loadC64(f);
 					break;
 				} else {
 					loadTI994A(f);