[Scummvm-git-logs] scummvm master -> b0442a673bbc59c98f57211792e1107b95b0e364
AndywinXp
noreply at scummvm.org
Sat Nov 7 01:27:01 UTC 2026
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .
Summary:
b0442a673b GRIM: IMUSE: Don't clear the lipsync buffer before loading a new file
Commit: b0442a673bbc59c98f57211792e1107b95b0e364
https://github.com/scummvm/scummvm/commit/b0442a673bbc59c98f57211792e1107b95b0e364
Author: AndywinXp (andywinxp at gmail.com)
Date: 2026-11-07T02:26:48+01:00
Commit Message:
GRIM: IMUSE: Don't clear the lipsync buffer before loading a new file
The original IMUSE.DLL reads each .LIP file into the slot buffer without
clearing it, so a file shorter than the previous one keeps the old
entries. gagl088.LIP is only an 8-byte stub, and the original lip-syncs
it with the entries of the previous line...
Changed paths:
engines/grim/imuse/imuse_files.cpp
diff --git a/engines/grim/imuse/imuse_files.cpp b/engines/grim/imuse/imuse_files.cpp
index b78af1f6830..b8ee1ff7dcc 100644
--- a/engines/grim/imuse/imuse_files.cpp
+++ b/engines/grim/imuse/imuse_files.cpp
@@ -1625,8 +1625,6 @@ int IMuse::loadLip(const char *lipsyncFilename, int soundId) {
int fileSize = lipsyncFile->size();
if (fileSize <= IMUSE_LIPSYNC_MAX_SIZE) {
- // Clear the old data, or it would be read after the end of the new file
- memset(_lipsyncBufs[slot], 0, sizeof(_lipsyncBufs[slot]));
lipsyncFile->read(_lipsyncBufs[slot], fileSize);
if (memcmp(_lipsyncBufs[slot], "LIP!", 4))
More information about the Scummvm-git-logs
mailing list