[Scummvm-git-logs] scummvm master -> b0e8703027f48bad992182f07e1db66fef585d38

lephilousophe noreply at scummvm.org
Sun Oct 11 18:14:37 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
b0e8703027 GUI: Don't rebuild the UnknownGameDialog at creation


Commit: b0e8703027f48bad992182f07e1db66fef585d38
    https://github.com/scummvm/scummvm/commit/b0e8703027f48bad992182f07e1db66fef585d38
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2026-10-11T20:14:17+02:00

Commit Message:
GUI: Don't rebuild the UnknownGameDialog at creation

At this time, the width is ridicuously small and text is split character
by character. This makes a huge number of lines.
This then causes a crash in the ScrollContainerWidget because the last
characters are placed at an y which overflows int16 on platforms with
big scale facor.

Fix #17159

Changed paths:
    gui/unknown-game-dialog.cpp


diff --git a/gui/unknown-game-dialog.cpp b/gui/unknown-game-dialog.cpp
index f7080feb5eb..6dc17a2417b 100644
--- a/gui/unknown-game-dialog.cpp
+++ b/gui/unknown-game-dialog.cpp
@@ -67,8 +67,6 @@ UnknownGameDialog::UnknownGameDialog(const DetectedGame &detectedGame) :
 	// Use a ScrollContainer for the report in case we have a lot of lines.
 	_textContainer = new ScrollContainerWidget(this, "UnknownGameDialog.TextContainer", "");
 	_textContainer->setTarget(this);
-
-	rebuild();
 }
 
 void UnknownGameDialog::handleMouseWheel(int x, int y, int direction) {




More information about the Scummvm-git-logs mailing list