[Scummvm-git-logs] scummvm master -> 4585340eead8c60b518acb03c9f0a3aaf9ee685e

sdelamarre noreply at scummvm.org
Mon Oct 26 04:12:08 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
4585340eea GOB: Fix a bug related to video flags reading


Commit: 4585340eead8c60b518acb03c9f0a3aaf9ee685e
    https://github.com/scummvm/scummvm/commit/4585340eead8c60b518acb03c9f0a3aaf9ee685e
Author: Simon Delamarre (simon.delamarre14 at gmail.com)
Date: 2026-10-26T05:11:39+01:00

Commit Message:
GOB: Fix a bug related to video flags reading

VideoPlayer::Properties.flags mixes original engine flags (16 bits) and
ScummVM specific flags in a 32 bits field. Sometimes, ScummVM specific
flags were wrongly set due to an accidental sign extension.

Fix some videos not being displayed in Adi4/Anglais

Changed paths:
    engines/gob/inter_v7.cpp


diff --git a/engines/gob/inter_v7.cpp b/engines/gob/inter_v7.cpp
index 09e7d4ac1d4..96e019b7c0c 100644
--- a/engines/gob/inter_v7.cpp
+++ b/engines/gob/inter_v7.cpp
@@ -730,7 +730,8 @@ void Inter_v7::o7_playVmdOrMusic() {
 	props.startFrame = _vm->_game->_script->readValExpr();
 	props.lastFrame  = _vm->_game->_script->readValExpr();
 	props.breakKey   = _vm->_game->_script->readValExpr();
-	props.flags      = _vm->_game->_script->readValExpr();
+	// Original engine flags use 16bits, higher bits are ScummVM specific flags set elsewhere (kFlagScreenSurface)
+	props.flags      = (uint16)_vm->_game->_script->readValExpr();
 	props.palStart   = _vm->_game->_script->readValExpr();
 	props.palEnd     = _vm->_game->_script->readValExpr();
 	props.palCmd     = 1 << (props.flags & 0x3F);




More information about the Scummvm-git-logs mailing list