[Scummvm-git-logs] scummvm master -> c843b5417887f3bd3f37f3e7cbd268d99314f0a7

AndywinXp noreply at scummvm.org
Fri Oct 30 15:52:57 UTC 2026


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
c843b54178 SCUMM: MI1: Fix #17438


Commit: c843b5417887f3bd3f37f3e7cbd268d99314f0a7
    https://github.com/scummvm/scummvm/commit/c843b5417887f3bd3f37f3e7cbd268d99314f0a7
Author: AndywinXp (andywinxp at gmail.com)
Date: 2026-10-30T16:52:45+01:00

Commit Message:
SCUMM: MI1: Fix #17438

"SCUMM: MI1/FM-TOWNS: Colors messed up in
The Secret of Monkey Island after load"

Turns out from the disassembly that the 16-color palette
used for the verbs and banners is not init with anything
at boot-up, and seems to use a zero-ed array instead.

So I just removed the check that I introduced in July 2025...

Changed paths:
    engines/scumm/palette.cpp


diff --git a/engines/scumm/palette.cpp b/engines/scumm/palette.cpp
index a3758d7f7df..1976800042b 100644
--- a/engines/scumm/palette.cpp
+++ b/engines/scumm/palette.cpp
@@ -254,7 +254,7 @@ void ScummEngine::resetPalette(bool isBootUp) {
 			if (_game.id == GID_INDY4 || _game.id == GID_MONKEY2)
 				_townsClearLayerFlag = 0;
 #ifdef USE_RGB_COLOR
-			else if (_game.id == GID_LOOM || _game.id == GID_MONKEY) // Setting a default for MI1 as well!
+			else if (_game.id == GID_LOOM)
 				towns_setTextPaletteFromPtr(tableTownsLoomPalette);
 			else if (_game.version == 3)
 				towns_setTextPaletteFromPtr(tableTownsV3Palette);




More information about the Scummvm-git-logs mailing list