[ scummvm-Patches-591581 ] Possible fix for bug #558711

[noreply at sourceforge.net]

Patches item #591581, was opened at 2002-08-06 17:05
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=591581&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: Possible fix for bug #558711

Initial Comment:
I think the problem reported in bug #558711  is in
o5_roomOps()'s "set palette color". In the
GF_SMALL_HEADER case, it will manipulate
_shadowPalette, which just won't do anything noticeable
here.

I have two experimental patches which both seem to do
the trick, albeit in different ways.

greatloom.diff sticks with the current _shadowPalette
solution, and changes updatePalette() to take this into
consideration if it's running a GF_SMALL_HEADER game.
Note that it now says _shadowPalette[b] = a instead of
_shadowPalette[a] = b. This is intentional. The
animation would be wrong otherwise, and colours that
shouldn't be remapped are.

greatloom2.diff adds a "backup" palette which stores a
copy of the current palette as it was first loaded, and
then uses setPalColor() to modify the current palette.

I think greatloom.diff is probably the better solution,
assuming it doesn't break anything else. Since Loom is
the only GF_SMALL_HEADER game that I own, and I haven't
gotten very far into it yet, I can't test this.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=591581&group_id=37116