[ scummvm-Patches-639931 ] ALL: Fix for possible mixer distortion

noreply at sourceforge.net noreply at sourceforge.net
Mon Nov 18 08:41:21 CET 2002


Patches item #639931, was opened at 2002-11-18 08:41
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=639931&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: ALL: Fix for possible mixer distortion

Initial Comment:
It looks to me as if there is a potential for
arithmetic overflow in the mixer with some of the
channel types. In reality I've only managed to provoke
a few popping sounds when cranking up all the volume
controls to their maximum setting, but I still think
it'd be safer to use clamped_add_16() than to just add
the sample to the buffer and assume it will work.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=639931&group_id=37116




More information about the Scummvm-tracker mailing list