[ scummvm-Patches-620625 ] Regression fix: Simon crashes on start

[noreply at sourceforge.net]

Patches item #620625, was opened at 2002-10-09 08:36
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=620625&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: Regression fix: Simon crashes on start

Initial Comment:
At least under UNIX the Simon games crashes on start-up
because GameDetector::createMidi() returns NULL.

I don't know enough about Simon to fix it properly
(e.g. by adding a MIDI -> AdLib converter or
implementing streaming - whatever that is - for the
MIDI drivers that don't have it), so what I do instead
is to return MidiDriver_NULL_create(), if it's a Simon
game and it would have otherwise returned NULL.

The patch also changes error() slightly so that the
Simon games can use it without crashing. The problem
here was that g_scumm was NULL, so it couldn't call
g_scumm->_system->quit(). I've changed it to use
g_system->quit() instead, even though g_system is
labelled as a "BIG HACK"


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=620625&group_id=37116