[ scummvm-Patches-696033 ] CMI: Actor scale experiment (don't apply)

SourceForge.net noreply at sourceforge.net
Sun Mar 2 16:06:17 CET 2003


Patches item #696033, was opened at 2003-03-02 16:06
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=696033&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: CMI: Actor scale experiment (don't apply)

Initial Comment:
This is an attempt to document what's known about the
bug that, among other things, causes Dinghy Dog to
shrink after he bites you. The patch is not meant to be
applied, but points at the general area where the
problem may be.

Dinghy Dog spends most of his time in walkbox 0, with
ignoreBoxes set to 1. Ordinarily the latter would keep
him from being scaled at all.

Somewhere along the way, SO_ACTOR_DEFAULT is invoked,
which causes ignoreBoxes to be set to 0.

While ignoreBoxes is 0, SO_ACTOR_COSTUME is invoked.
This calls setActorCostume(), which calls showActor(),
which calls adjustActorPos(), which calls setBox(),
which puts him in walkbox 7 and scales him to the
appropriate size for this box.

Later he's put back in box 0 again, but at this point
ignoreBoxes has been set to 1 again, so he won't be
scaled back.

My first idea was to remove the ignoreBoxes check from
setupActorScale, but this caused Murray to be drawn
unscaled in the same room. This is clearly the wrong
behaviour. What the patch does is simply to keep
SO_ACTOR_DEFAULT from changing ignoreBoxes, but even if
this turns out to be the correct solution, it's a hacky
implementation.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=696033&group_id=37116




More information about the Scummvm-tracker mailing list