[ scummvm-Patches-738859 ] Experimental costume.cpp cleanup (don't apply)

[SourceForge.net]

Patches item #738859, was opened at 2003-05-16 18:57
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=738859&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: Experimental costume.cpp cleanup (don't apply)

Initial Comment:
Something I've been wondering about for a long time now
is whether or not we actually need all the different
proc*() functions in costume.cpp. As far as I can tell,
they're all the same function, optimized for different
circumstances.

But is that optimization noticeable on today's
hardware? If not, all they do is to make the code less
maintainable.

This patch removes all the proc*() functions, except
one which has been slightly extended. I don't know if
making this change is a good idea or not, but I think
it's worth discussing. It would cut the size of
costume.cpp to about half its current size.

Mind you, I haven't tested this very much yet. In
particular, I don't have any of the Amiga data files,
so I may very well have broken those games horribly.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=738859&group_id=37116