[ scummvm-Feature Requests-812913 ] ST sound

[SourceForge.net]

Feature Requests item #812913, was opened at 2003-09-26 08:57
Message generated for change (Comment added) made by hibernatus
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418823&aid=812913&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Thomas Combeleran (hibernatus)
Assigned to: Jochen Hoenicke (hoenicke)
Summary: ST sound

Initial Comment:
PlayerV2 without the lowpass filter sounds very close to 
the original ST engines.
So adding an option to disable the filter would be nice.
But is still doesn't sound perfect:

ST emulator without any filter:
http://hibernatus34.free.fr/pv/saint_raw.wav
ScummVM without the lowpass filter:
http://hibernatus34.free.fr/pv/scummvm_raw.wav

ST emulator with its (light) filter:
http://hibernatus34.free.fr/pv/saint_lowpass.wav
ScummVM with the filter:
http://hibernatus34.free.fr/pv/scummvm_lowpass.wav

(The ST emulator really sounds nearly perfect)

What's strange is that all the samples in the ScummVM 
output are positive. Is it a bug?


----------------------------------------------------------------------

>Comment By: Thomas Combeleran (hibernatus)
Date: 2003-10-10 16:25

Message:
Logged In: YES 
user_id=750069

I like how it sounds with PCJR_DECAY = 0xee80. But i don't 
know if the other users would agree.
At least i can say it sounds closer to my memories.

----------------------------------------------------------------------

Comment By: Jochen Hoenicke (hoenicke)
Date: 2003-09-29 22:34

Message:
Logged In: YES 
user_id=18252

Okay I looked what needs to be changed to get signed samples.  
I will check it in as soon as I cleaned it up.  
  
I'm not sure if it makes sense to add a global option for  
something so specific as the low pass filter for -epcjr/-epcspk  
engines. BTW, you can easily make the filter lighter by  
decreasing  PCJR_DECAY, maybe you can find a better setting.  
  

----------------------------------------------------------------------

Comment By: Max Horn (fingolfin)
Date: 2003-09-27 19:14

Message:
Logged In: YES 
user_id=12935

Regarding your question: "What's strange is that all the samples in 
the ScummVM  output are positive. Is it a bug?"

-> it would seem to me that it is a bug, yeah. I noticed earlier 
that Player_V2::squareGenerator generates only positive samples, 
and wondered about it, but at that time didn't want to mess with 
code that *seems* to work - rather let hoenicke do that :-). 
Player_V2::lowPassFilter() also would have to be "fixed", I guesss, 
maybe more.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418823&aid=812913&group_id=37116