[ scummvm-Patches-991536 ] COMI: Possible fix/workaround for bug #754419

[SourceForge.net]

Patches item #991536, was opened at 2004-07-15 14:11
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=991536&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Torbjörn Andersson (eriktorbjorn)
Assigned to: Nobody/Anonymous (nobody)
Summary: COMI: Possible fix/workaround for bug #754419

Initial Comment:
I've already attached this in a comment to the bug
report, but it may be more noticeable here. It's an
attempt to fix, or at least work around, the annoying
graphics glitch that causes Wally's floating head to
appear while he's crying.

The reasoning behind the workaround is that Wally's
crying is done in "mumble" mode. That means that when
he starts talking and when he stops talking, we do not
call startAnimActor() with his
talkStartFrame/talkStopFrame.

However, when the "chore limb frame" opcode is used to
move his mouth - and COMI does this all the time,
presumably for lip sync - we cheerfully allow it to do
talk animations. In Wally's case, the talk animation is
either his hook on the ground, or - once you leave and
re-enter the room - his head  facing left near the cannon.

So it seems likely and reasonable to me that the
original had to block talk animations when the
character was mumbling. Perhaps not at this particular
point in the code, or in the way I did it, but *somewhere*.

I haven't given this patch much testing, but so far it
seems like an improvement.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=991536&group_id=37116