[ scummvm-Patches-1186858 ] GM/GS/MT-32 Init Patch

SourceForge.net noreply at sourceforge.net
Wed Apr 20 20:24:09 CEST 2005


Patches item #1186858, was opened at 2005-04-20 14:24
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1186858&group_id=37116

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: tbcarey (tbcarey)
Assigned to: Nobody/Anonymous (nobody)
Summary: GM/GS/MT-32 Init Patch

Initial Comment:
Patch to the earlier quicky patch. It should fix the
following things:

1) Prevent FMTowns games from initializing as MT32 or
GM or GS, which in turn prevents a crash caused by GS
init calling midi->getPercussionChannel(), which YM2162
driver seems to be unable to handle (at least in this
case).

2) Prevents null midi games from doing the same, when
they shouldn't anyway.

3) Prevents MT-32 emulation (Munt) from doing GS init,
which can mess up some of its percussion settings, etc.

The first two problems are caused because any non-Adlib
sound driver that uses the imuse parser (as opposed to
pc speaker, pcjr which don't) will return true for
_midi_native. This shouldn't be the case, but it
appears that _midi_native is only set up to be opposed
to _adlib_native, so when if clauses are used to
determine if an mt-32/gm specific portion of the code
should run, YM2162 and NULL drivers still do so. This
should prevent that, although the label '_midi_native'
is still somewhat misleading.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418822&aid=1186858&group_id=37116




More information about the Scummvm-tracker mailing list