[ scummvm-Bugs-1216439 ] run-length slice typo in online source

SourceForge.net noreply at sourceforge.net
Tue Jun 7 16:50:05 CEST 2005


Bugs item #1216439, was opened at 2005-06-07 09:50
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1216439&group_id=37116

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Graphics
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: cNewman (bilight52)
Assigned to: Nobody/Anonymous (nobody)
Summary: run-length slice typo in online source

Initial Comment:
this may be totally old but it tripped me up:

	if (dx >= dy) {

		min_run = dx / dy;
		error_up = (dx % dy) * 2;
		error_down = dy * 2;
		error = (dx % dy) - (dy * 2);
		init_run = (min_run / 2) + 1; // ALSO DO THIS.. min_run>>1+1
		end_run = init_run;

		if ((error_up == 0) && (min_run & 0x01) == 0) {
			init_run--;
		}
		
//////// error += dy; ///////// typo?error
//corrected code according to abrash
		
		if ((min_run & 0x01) != 0) {
			error += dy;
		}
		
//////////////////////////////////
this code is the xmajor section of the run-length slice routine
adapted from abrash. The bug often offsets the line by 1x-pixel.
the code 'error += dy' should read as above.

thanks-cNewman

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1216439&group_id=37116




More information about the Scummvm-tracker mailing list