[ scummvm-Bugs-1160977 ] gfx-mode in command line will ignore -f option

[SourceForge.net]

Bugs item #1160977, was opened at 2005-03-10 23:59
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1160977&group_id=37116

Category: Launcher/Install
Group: All Games
Status: Open
Resolution: None
Priority: 5
Submitted By: Uwe Ryssel (uweryssel)
Assigned to: Nobody/Anonymous (nobody)
Summary: gfx-mode in command line will ignore -f option

Initial Comment:
ScummVM version 0.7.0

If gfxmode and fullscreen options are set in command line
and -f is set after -g..., the fullscreen option will be ignored.

So
"scummvm -f -g<gfx-mode>"
doesn't work and
"scummvm -g<gfx-mode> -f"
works.
(replace <gfx-mode> with your favourite gfx-mode, not normal or default)

I've found the bug in gamedetector.cpp and sdl.cpp.
Those actions are done in GameDetector::parseCommandLine
if options are -f -g...:

1. parsing of -g option (options parsed backwards)

which means:

- create backend instance (wasn't created yet)
- backend constructor reads fullscreen config value

2. parsing of -f option

Now it's to late to update fullscreen config value,
"fullscreen" won't be checked from backend again.

This bug concerns all options which set
in backend constructors and set before -g option.
In SDL backend they're "joystick_num", "use_GDI",
"fullscreen" and "aspect_ratio".
								  


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418820&aid=1160977&group_id=37116